From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756061AbbIUF3L (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Sep 2015 01:29:11 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:33431 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755956AbbIUF3J (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Sep 2015 01:29:09 -0400
Date: Sun, 20 Sep 2015 22:29:08 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de,
        apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com,
        Jake Oshins <jakeo@microsoft.com>
Subject: Re: [PATCH 3/3] drivers:hv: Define the channel type for Hyper-V PCI
 Express pass-through
Message-ID: <20150921052908.GD24350@kroah.com>
References: <1442366782-23929-1-git-send-email-kys@microsoft.com>
 <1442366809-23968-1-git-send-email-kys@microsoft.com>
 <1442366809-23968-3-git-send-email-kys@microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1442366809-23968-3-git-send-email-kys@microsoft.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 15, 2015 at 06:26:49PM -0700, K. Y. Srinivasan wrote:
> From: Jake Oshins <jakeo@microsoft.com>
> 
> This defines the channel type for PCI front-ends in Hyper-V VMs.
> 
> Signed-off-by: Jake Oshins <jakeo@microsoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  include/linux/hyperv.h |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index ea0a0e3..5587899 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -1140,6 +1140,17 @@ u64 hv_do_hypercall(u64 control, void *input, void *output);
>  		}
>  
>  /*
> + * PCI Express Pass Through
> + * {44C4F61D-4444-4400-9D52-802E27EDE19F}
> + */
> +
> +#define HV_PCIE_GUID \
> +	.guid = { \
> +			0x1D, 0xF6, 0xC4, 0x44, 0x44, 0x44, 0x00, 0x44, \
> +			0x9D, 0x52, 0x80, 0x2E, 0x27, 0xED, 0xE1, 0x9F \
> +		}
> +
> +/*
>   * Common header for Hyper-V ICs
>   */

Yet you do nothing with this, so why add it to the code at this point in
time?  I can't take pointless things like this...