From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] avr32: fix build failure
Date: Mon, 21 Sep 2015 08:09:42 +0200 [thread overview]
Message-ID: <20150921060942.GA17632@samfundet.no> (raw)
In-Reply-To: <1442682779-20077-2-git-send-email-sudipm.mukherjee@gmail.com>
Around Sat 19 Sep 2015 22:42:57 +0530 or thereabout, Sudip Mukherjee wrote:
> While building avr32 with allmodconfig, the build used to fail with the
> message:
> error: implicit declaration of function 'pci_iomap'
> error: implicit declaration of function 'pci_iounmap'
What has changed recently that start pulling in these? AVR32 does not have
PCI at all, and will never have it either. Is this exposing a bug somewhere
else?
> Create dummy pci_io{map,unmap} functions to fix the build.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> Tested with defconfig, allmodconfig, allnoconfig and merisc_defconfig.
> Build is at:
> https://travis-ci.org/sudipm-mukherjee/parport/builds/81168845
>
> Partial idea taken from:
> 78857614104a ("MIPS: Expose missing pci_io{map,unmap} declarations")
> which solved a similar problem with mips.
>
> arch/avr32/include/asm/io.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/avr32/include/asm/io.h b/arch/avr32/include/asm/io.h
> index f855646..1d8c4e4 100644
> --- a/arch/avr32/include/asm/io.h
> +++ b/arch/avr32/include/asm/io.h
> @@ -276,6 +276,19 @@ extern void __iomem *__ioremap(unsigned long offset, size_t size,
> unsigned long flags);
> extern void __iounmap(void __iomem *addr);
>
> +#ifndef CONFIG_PCI
> +struct pci_dev;
> +static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
> +{
> +}
> +
> +static inline void __iomem *pci_iomap(struct pci_dev *dev, int bar,
> + unsigned long maxlen)
> +{
> + return NULL;
> +}
> +#endif
> +
> /*
> * ioremap - map bus memory into CPU space
> * @offset bus address of the memory
--
mvh
Hans-Christian Egtvedt
next prev parent reply other threads:[~2015-09-21 6:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 17:12 [PATCH 0/3] fix allmodconfig failure of avr32 Sudip Mukherjee
2015-09-19 17:12 ` [PATCH 1/3] avr32: fix build failure Sudip Mukherjee
2015-09-21 6:09 ` Hans-Christian Egtvedt [this message]
2015-09-21 6:39 ` Sudip Mukherjee
2015-09-21 7:33 ` Hans-Christian Egtvedt
2015-09-21 8:01 ` Sudip Mukherjee
2015-09-23 15:56 ` Sudip Mukherjee
2015-09-23 17:15 ` Hans-Christian Egtvedt
2015-09-24 10:23 ` Sudip Mukherjee
2015-09-19 17:12 ` [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency Sudip Mukherjee
2015-09-20 16:15 ` Felipe Balbi
2015-09-21 11:10 ` Sudip Mukherjee
2015-09-23 15:52 ` Sudip Mukherjee
2015-09-30 16:04 ` Felipe Balbi
2015-09-30 16:24 ` Sudip Mukherjee
2015-09-30 16:34 ` Nicolas Ferre
2015-09-30 16:53 ` Sudip Mukherjee
2015-09-30 17:12 ` Nicolas Ferre
2015-10-01 12:56 ` Sudip Mukherjee
2015-10-01 16:12 ` Sudip Mukherjee
2015-09-19 17:12 ` [PATCH 3/3] page-flags: rectify forward declaration Sudip Mukherjee
2015-09-21 22:35 ` Andrew Morton
2015-09-22 8:56 ` Sudip Mukherjee
2015-09-24 15:27 ` Sudip Mukherjee
2015-09-24 14:50 ` [PATCH 00/16] Refreshed page-flags patchset Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 01/16] page-flags: trivial cleanup for PageTrans* helpers Kirill A. Shutemov
2015-09-24 15:44 ` Christoph Lameter
2015-09-24 14:50 ` [PATCH 02/16] page-flags: move code around Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 03/16] page-flags: introduce page flags policies wrt compound pages Kirill A. Shutemov
2015-09-25 12:29 ` Konstantin Khlebnikov
2015-09-25 19:13 ` Kirill A. Shutemov
2015-09-28 10:02 ` Konstantin Khlebnikov
2015-09-28 11:03 ` Kirill A. Shutemov
2015-09-28 11:48 ` Konstantin Khlebnikov
2015-09-28 17:51 ` Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 04/16] page-flags: define PG_locked behavior on " Kirill A. Shutemov
2015-09-24 16:08 ` Christoph Lameter
2015-09-24 20:26 ` Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 05/16] page-flags: define behavior of FS/IO-related flags " Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 06/16] page-flags: define behavior of LRU-related " Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 07/16] page-flags: define behavior SL*B-related " Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 08/16] page-flags: define behavior of Xen-related " Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 09/16] page-flags: define PG_reserved behavior " Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 10/16] page-flags: define PG_swapbacked " Kirill A. Shutemov
2015-09-24 14:50 ` [PATCH 11/16] page-flags: define PG_swapcache " Kirill A. Shutemov
2015-09-24 14:51 ` [PATCH 12/16] page-flags: define PG_mlocked " Kirill A. Shutemov
2016-04-18 19:44 ` Sasha Levin
2016-05-18 14:02 ` Kirill A. Shutemov
2015-09-24 14:51 ` [PATCH 13/16] page-flags: define PG_uncached " Kirill A. Shutemov
2015-09-24 14:51 ` [PATCH 14/16] page-flags: define PG_uptodate " Kirill A. Shutemov
2015-09-24 14:51 ` [PATCH 15/16] page-flags: look at head page if the flag is encoded in page->mapping Kirill A. Shutemov
2015-09-24 14:51 ` [PATCH 16/16] mm: sanitize page->mapping for tail pages Kirill A. Shutemov
2015-09-25 2:20 ` Jerome Glisse
2015-09-24 16:13 ` [PATCH 00/16] Refreshed page-flags patchset Christoph Lameter
2015-09-24 20:25 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921060942.GA17632@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).