From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756160AbbIUHnY (ORCPT ); Mon, 21 Sep 2015 03:43:24 -0400 Received: from mail-bn1bon0146.outbound.protection.outlook.com ([157.56.111.146]:65495 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756009AbbIUHnW (ORCPT ); Mon, 21 Sep 2015 03:43:22 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=none action=none header.from=freescale.com; Date: Mon, 21 Sep 2015 14:30:27 +0800 From: Peter Chen To: CC: , , "Greg Kroah-Hartman" , Felipe Balbi , Andrzej Pietrasiewicz Subject: Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Message-ID: <20150921063026.GB15180@shlinux2> References: <1442596361-404-1-git-send-email-eu@felipetonello.com> <1442596361-404-3-git-send-email-eu@felipetonello.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1442596361-404-3-git-send-email-eu@felipetonello.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD034;1:+6H6xm2AYZNn8+MHfy1DDJCEmHa/LQnIY9uxp+bVSuZK4AAnT+Gf5AOSwy+Bm4+eq0SLfFUNw2wCQlf7owmcXNu3a8zi+b2SMN+Nh2FTdfiXdHUkRj47bsVU1hpO+EvgWa4plDe5mDVtP91/toN4+8uaUjRnOmUXXKvTZ5akGkMS3l3eRG7jPX7uIuuIuUW/FCLZfirozGMDqIv/B+Flu4AH54bw9T1bNgaF4zM6XPSkUgUuS28BhOqVOT9Qk8eycyFuhDhiHCeiGjw1/pZYt2aVOX+J10G73F2/uMbffrJfZzzWEkDms43Bd9jO1aYqnKw+tawmewCtBY8OzDuSp8qybrTR4nRDz3YlymVGzC1hfGSeUmJkS0rXtU25ND2b X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(199003)(189002)(97736004)(46406003)(4001350100001)(47776003)(87936001)(19580405001)(5001860100001)(6806004)(64706001)(104016003)(4001540100001)(81156007)(2351001)(92566002)(46102003)(11100500001)(19580395003)(2950100001)(105606002)(189998001)(106466001)(110136002)(5001830100001)(62966003)(77096005)(83506001)(77156002)(68736005)(97756001)(86362001)(50986999)(76176999)(54356999)(33656002)(33716001)(50466002)(85426001)(23726002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB1268;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1268;2:VgLNAszP/aFvQtRVHvD2MsrxsvYi+jnHXEFR1lH89e3ww0Uuzo/8H2UO7sLt3slhdmmsxVC4/hpShCDDO03dcVCNGJehEF/BqmsSTQ+QZoSzEFqcEA1lJn0FXVlaH1dRJo09EGCrV1e7Fv8pe5YyDhCUejpiEmxQzy2AmZFik/o=;3:45gx/DoUwGGZRbgp2j1UkUgHj/944KET+wtAX5ou7e0SzdDGeMS++ll721GF42b+BCc9j/gweZXaJisT8LuMD92dZl3K5HFv1oEJKv+PArW6G3IRUVlSp/a5JVV0H1daP80cmC9uEXS6c0dkHnzXdw4hGhrYXIRdcRQO45kw7yQt6xrXeOpP3NpU3nKyrogCa2s9qjWtMH/i+j8+KU5UcggVULS3UtHYXKBoI6Gv9xw=;25:NHxCTsBcpWnL3Jg3T95thS70ucolxC/9Ue/d30Nr5T/MabIVPGFMRUYzo+fR+7wsBNWvLPwTOmMirEs3X9pzL95+/E7DxcHDUySHFAyhFCJQ+ssIQ4A2nyQvWrk7AP2uTTBWmGhEjQigLVfpaeoJ3Xh3N2v5w0ztr+Ggh/fJi+0L9/2pZKKbL3gE/uF/eGSe75QExRLXeA6gDtlOAqGoYRsgprWXwJ1TniGRqgemnrmGJe5lxWZ6lS9rqAaEmQ/ctPD/EHdA3ncgscC8OT26+g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1268; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1268;20:+bO5NIdHHVzXi43JRCHy98XecGJtreKkD2/pSpjmYq/mTR1f/gYFu6ZPLIzFfkDqQumCM7uxArGjJ2im4aTNaEW/6JUb8GBz84FCJONA50gMyOTJTe8qXGCURYAsrJ4Tm6lmsVOeePVMSQd+1NRYNj+8jhYe6gSkD8AwRzQPVepDPq0TVerm1e47uxwP6mw1FZBTvHKu20nIN51SgwD6PMhOXEbdzkZ5eOFWY0VFuQ9A1TmyqjbenWOPuR6iZEXpH77TATcn4n3pHzi0evjD80FnhsUOFwAkYkTc3hTvhF4kx8ZsF/02g29SBS7z3eCLW3/8nMEfIaKV6yI5nrB34GIHAfffL4UZJFfRmEcmxd4=;4:PblNFnmO7dYzmTvlmZhBONjDU7KCkxZPMQPivnzsWllg4UXYpuFeivhnEs9H3pzrH4HQBSKo68nUwVq6lqfTTYJyuCAndbI/jmGgq14pd8SRQX+e5+aLVs8w1tNqUYnecL662U5SUr8+k+MAB65cF1tsCAhWZayLCs7dy6v3l/71xQNOshMXA7oYtvdrZtcrjYfNU2GB/Anp0taHY9I5p/kVGDWFN4z8+nI1Gk76GHG2L6kMXxdUFVdIXzf231Il X-Exchange-Antispam-Report-CFA: BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1268;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1268; X-Forefront-PRVS: 07063A0A30 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0301MB1268;23:kWk5TOQZOEzMzeFPCtFuQrqaL+Dz39+upwGJP7A?= =?us-ascii?Q?olmMa4bLNnJOCJzKc9a9gQ6FYuWsdtuWoY4EtxxgN1kQz7/oT75GtjJTU/Lo?= =?us-ascii?Q?LGeR3E9uhYonoGNKWGMYrnSu2vE91G7BfUKr0siNGijcEJKwccPSbocYKJJ6?= =?us-ascii?Q?jOVZjmrVga31Zs7pJrW/m1SqA26cJSZjOqnxXV4LZ70/yBUk3NkhubMaDM5m?= =?us-ascii?Q?JPbmrhnF0cWfjGXMK6GOPufv1URL+BtjmkM+th6L8cZBmldk6LdZhZh1aJKW?= =?us-ascii?Q?UkiwosqZiwN4efkG7pOZ8/PzT7Anlu/MZM5xoaQG01Yx+kDgyTRqtDFVu1Xq?= =?us-ascii?Q?GBs2SX1ADxreVEUQ4iUYwg5Ng6axRPuo0oT6kJ2tKHOLb+QfqxfxU4KqF2Gv?= =?us-ascii?Q?KCDpE3STkkGJWRiE538ormdK5asYlrerDRf+X9IuHXJmu9ITdhi5hsTXLL64?= =?us-ascii?Q?ADiI5cSQ+lRx/7AdjzjNLkA1XtvH+jI9+DF8xVePZ6Z4ye5MLQS92U7YXtQb?= =?us-ascii?Q?8gctvhA0DaOZiF2MgWXsFPwMeYXqSBk95R7AdI4nh65D4cFbIUr53WChX15h?= =?us-ascii?Q?XMx9RP+dU3ItZwyvCSp1L9hSdQwpjmUYb7+jWML7YK4TwUzeYe2C/SepmQK6?= =?us-ascii?Q?kdSC8kcIFb3/1Bd7gwAnIWPJg/iUQZqy9e4oXP1nwtEzw1kfAIRQ1DCMoe5T?= =?us-ascii?Q?75gOx3LKqC2iJte5BwBkGrMxM80mvKQRxwlMygebXpOY8LXn1uY1+lScmIqP?= =?us-ascii?Q?+941m6hN9ua4D77S6aNlYGHOeLOyqpbfzyhXUo65SwB4RZ6FQBd8sV4Kl4Je?= =?us-ascii?Q?sNNBJxT2VYYDdfL0ak+yjAc5aCz/arF/k44juRWBHtF/d7V41Gu3iWxS0egr?= =?us-ascii?Q?YV9JhrOwBg+C7HjWZAFSTwvG5hWd9GvWKsUHvp2mUxJ6lYi8+REkhbxJKokw?= =?us-ascii?Q?crPT7qR60ljWgjVNWtq8RgGM1wdtHJK3pUt9oQSu2uhT0ossiWXw/3lJWxZU?= =?us-ascii?Q?PsKpTH8XfTMXX74E5gWrhsHvEdZ4wAocE53BylVxsq74NzRGhmqtCudl3oMO?= =?us-ascii?Q?EEpJ50+U19FpQyDiTHc0PTlL8/jqXQRjGFmYk64V7G0KXEmwoYEUPfA21ois?= =?us-ascii?Q?MCnNWqCgylayOmVXecSxZiJgJ59sh4aWyc9XnnKkkRgocVTY4UOne53WIHFm?= =?us-ascii?Q?q+B9ZLmK9oQtRuIPGqZ6effYUSrsf60Uk5eGh?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1268;5:xcvFwytOn+yfcxMmGWVnDl5pt8OOcmyXtez/RSUHZ5m1sdLeg/btefgFt3Y+0rV09PRJLiWzju0rdtllWZ3TAMAP5gDji5jYt3dEKf9oX0cA9IQopSDDLu4cG5KockGS4QGg62No02pyBHwpPgHcnA==;24:yq2PBIEwzqio26xmcaIidy9S4XkjVLipqT2YR++hare+W6cDQ458JnGltanHEHmK7DZ7YfcQAJTaefHrX50OUlhW07m4KUaZOsXaimmNXNM=;20:L9KTEgxkbJHC5iE0Pt5WPReRoWu4bCLD8YgsRbkXTkuQcxMApXCKNsjEm1pKxDb7VQ/dadbpr7GAsCaryMziFw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2015 07:43:17.7487 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1268 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 06:12:41PM +0100, eu@felipetonello.com wrote: > From: "Felipe F. Tonello" > > f_midi is not checking weather the is an error on usb_ep_queue %s/weather/whether %s/the/there > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index ad50a67..a5e446d 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req) > } > } > > - if (req->length > 0) > - usb_ep_queue(ep, req, GFP_ATOMIC); > + if (req->length > 0) { > + int err; > + > + err = usb_ep_queue(ep, req, GFP_ATOMIC); > + if (err < 0) > + ERROR(midi, "%s queue req: %d\n", > + midi->out_ep->name, err); > + } > else > free_ep_req(ep, req); > } > -- > 2.1.4 > -- Best Regards, Peter Chen