From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756267AbbIUIdt (ORCPT ); Mon, 21 Sep 2015 04:33:49 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:33859 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756176AbbIUIdr (ORCPT ); Mon, 21 Sep 2015 04:33:47 -0400 Date: Mon, 21 Sep 2015 10:33:45 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "Andrew F. Davis" Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Dan Murphy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS Message-ID: <20150921083345.GE20113@pali> References: <1442265973-32261-1-git-send-email-afd@ti.com> <1442265973-32261-2-git-send-email-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1442265973-32261-2-git-send-email-afd@ti.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 14 September 2015 16:26:07 Andrew F. Davis wrote: > The MODULE_DEVICE_TABLE macro automatically adds all needed > i2c MODULE_ALIASes so remove the extra MODULE_ALIAS. > > Signed-off-by: Andrew F. Davis Acked-by: Pali Rohár > --- > drivers/power/bq27x00_battery.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c > index 8287261f..d0b2f3b 100644 > --- a/drivers/power/bq27x00_battery.c > +++ b/drivers/power/bq27x00_battery.c > @@ -1120,10 +1120,6 @@ module_exit(bq27x00_battery_exit); > MODULE_ALIAS("platform:bq27000-battery"); > #endif > > -#ifdef CONFIG_BATTERY_BQ27X00_I2C > -MODULE_ALIAS("i2c:bq27000-battery"); > -#endif > - > MODULE_AUTHOR("Rodolfo Giometti "); > MODULE_DESCRIPTION("BQ27x00 battery monitor driver"); > MODULE_LICENSE("GPL"); -- Pali Rohár pali.rohar@gmail.com