From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756411AbbIUJvR (ORCPT ); Mon, 21 Sep 2015 05:51:17 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:19743 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbbIUJvQ (ORCPT ); Mon, 21 Sep 2015 05:51:16 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 21 Sep 2015 02:45:27 -0700 Date: Mon, 21 Sep 2015 11:51:06 +0200 From: Thierry Reding To: Douglas Anderson , Russell King CC: , , , , , , , Subject: Re: [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin Message-ID: <20150921095104.GB20992@ulmo.nvidia.com> References: <1442436098-26608-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 In-Reply-To: <1442436098-26608-1-git-send-email-dianders@chromium.org> X-NVConfidentiality: public User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) X-Originating-IP: [10.2.71.243] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cvVnyQ+4j833TQvp" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cvVnyQ+4j833TQvp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 16, 2015 at 01:41:38PM -0700, Douglas Anderson wrote: > There's a member in 'struct dw_hdmi' called cable_plugin. It's never > set to anything anywhere so thus is always false. There's a bit of code > checking it, but since it's always false this must be dead code. > Eliminate it. >=20 > Note: if someone wants to figure out the intention of the original code > and implement whatever feature / fix was needed then we can drop this > patch. The 'cable_plugin' member has been unused since the code was > first added in (9aaf880 imx-drm: Add mx6 hdmi transmitter support). >=20 > Signed-off-by: Douglas Anderson > --- > drivers/gpu/drm/bridge/dw_hdmi.c | 9 --------- > 1 file changed, 9 deletions(-) Except for the CHROMIUM: prefix this looks good to me: Reviewed-by: Thierry Reding Russell, do you have patches to this driver queued for v4.4 and plan to pick this up into your tree or should I take it? Thierry >=20 > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw= _hdmi.c > index 0083d4e..ba90885 100644 > --- a/drivers/gpu/drm/bridge/dw_hdmi.c > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c > @@ -115,7 +115,6 @@ struct dw_hdmi { > int vic; > =20 > u8 edid[HDMI_EDID_LEN]; > - bool cable_plugin; > =20 > bool phy_enabled; > struct drm_display_mode previous_mode; > @@ -1203,12 +1202,6 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi = *hdmi) > hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF); > } > =20 > -static void hdmi_enable_overflow_interrupts(struct dw_hdmi *hdmi) > -{ > - hdmi_writeb(hdmi, 0, HDMI_FC_MASK2); > - hdmi_writeb(hdmi, 0, HDMI_IH_MUTE_FC_STAT2); > -} > - > static void hdmi_disable_overflow_interrupts(struct dw_hdmi *hdmi) > { > hdmi_writeb(hdmi, HDMI_IH_MUTE_FC_STAT2_OVERFLOW_MASK, > @@ -1285,8 +1278,6 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, stru= ct drm_display_mode *mode) > hdmi_tx_hdcp_config(hdmi); > =20 > dw_hdmi_clear_overflow(hdmi); > - if (hdmi->cable_plugin && hdmi->sink_is_hdmi) > - hdmi_enable_overflow_interrupts(hdmi); > =20 > return 0; > } > --=20 > 2.6.0.rc0.131.gf624c3d >=20 --cvVnyQ+4j833TQvp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJV/9MGAAoJEN0jrNd/PrOh91sP/iMtPoeT49813xvvEy5G4E4P B6muwOzrTYRGvskRg3H1L8afUIyALrMg/qFvfTVsf/oLo6Tn4hPl8S5Aq2AaMKdK xU16j8bjAc6NtldOllVy1f1JQn/4Az05cZzNaoJSHcYNrDndCBkza7Tv2EQZrEaF 9KRGaVCorBgUN6uPjPyPu1D3YlAkFFZ3uq9j4PYmkJ76yRE2l7k2y26qNZHU4Rdj I7sEJqGNNdH6pBPsTwhub5G3DoYjufUns8wdn09g79XB/o55oXv0rtexyeZ4XmTv FZ+PHsNpRAvHT4kmsFbSBUeYW8d6jHMmPxcFF4LORcYwh3BWoEFoWdS0cNV9i9Gf 4/8UDfz6ytVPrlcA64pFBYvqs1Eqq7GdoeitMNjqJR3ovZbmHev6nZk1bByfo7aq puRARsUFxp2287sJ89MRZzC+4Fbs0l8UMGsy6tvccZRWzHW+JyPaxTp6mLeTf73k XecCmup2ewd7mkwC8OCErFwXV7TGi+Tn9rX+z/XaP1NLMoHicPzC8JwrATxiH1lP /gnqnSOgFLZvYZUnHqpnLRIOd2oj7InQQDXFEzwFmO0QD1QHsKbme3UY8fynASBq u4foS6fC5lcVwL1v8mtDe56SEeFb5ok/lqJh0FNEsQVj1+MEE7Cw3NC6ntpagN3d 3PN53WNayhXASzMPYgiw =XHha -----END PGP SIGNATURE----- --cvVnyQ+4j833TQvp--