From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932204AbbIUKSd (ORCPT ); Mon, 21 Sep 2015 06:18:33 -0400 Received: from mo4-p04-ob.smtp.rzone.de ([81.169.146.178]:44241 "EHLO mo4-p04-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756470AbbIUKSb (ORCPT ); Mon, 21 Sep 2015 06:18:31 -0400 X-RZG-CLASS-ID: mo04 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWtqWFmrC5F/k87927aG Date: Mon, 21 Sep 2015 12:18:26 +0200 From: Olaf Hering To: "K. Y. Srinivasan" , Greg KH Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Subject: Re: [PATCH 4/5] hv: kvp: use wrappers to propaigate state Message-ID: <20150921101826.GA4252@aepfle.de> References: <1442363823-22428-1-git-send-email-kys@microsoft.com> <1442363874-22508-1-git-send-email-kys@microsoft.com> <1442363874-22508-4-git-send-email-kys@microsoft.com> <20150921052625.GB24350@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150921052625.GB24350@kroah.com> User-Agent: Mutt/1.5.24 (6503) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 20, Greg KH wrote: > On Tue, Sep 15, 2015 at 05:37:53PM -0700, K. Y. Srinivasan wrote: > > @@ -122,8 +125,8 @@ static void kvp_timeout_func(struct work_struct *dummy) > > + if (kvp_get_state() > HVUTIL_READY) > > + kvp_set_state(HVUTIL_READY); > And what if the state changed the line after this? Oops, your code is > hosed. See, you need a lock, do this correctly. KY, can this happen? Olaf