public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: david.vrabel@citrix.com, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/x86: Don't try to write syscall-related MSRs for PV guests
Date: Mon, 21 Sep 2015 11:30:35 -0400	[thread overview]
Message-ID: <20150921153034.GD13722@l.oracle.com> (raw)
In-Reply-To: <1442840968-23052-1-git-send-email-boris.ostrovsky@oracle.com>

On Mon, Sep 21, 2015 at 09:09:28AM -0400, Boris Ostrovsky wrote:
> For PV guests these registers are set up by hypervisor and thus
> should not be written by the guest. The comment in xen_write_msr_safe()
> says so but we still write the MSRs, causing the hypervisor to
> print a warning.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> ---
>  arch/x86/xen/enlighten.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 30d12af..1f1dbd2 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1077,6 +1077,7 @@ static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high)
>  		/* Fast syscall setup is all done in hypercalls, so
>  		   these are all ignored.  Stub them out here to stop
>  		   Xen console noise. */
> +		break;
>  
>  	default:
>  		if (!pmu_msr_write(msr, low, high, &ret))
> -- 
> 2.1.0
> 

  reply	other threads:[~2015-09-21 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 13:09 [PATCH] xen/x86: Don't try to write syscall-related MSRs for PV guests Boris Ostrovsky
2015-09-21 15:30 ` Konrad Rzeszutek Wilk [this message]
2015-09-28 13:24 ` [Xen-devel] " David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150921153034.GD13722@l.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox