From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757168AbbIUPnH (ORCPT ); Mon, 21 Sep 2015 11:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47211 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757123AbbIUPnF (ORCPT ); Mon, 21 Sep 2015 11:43:05 -0400 Date: Mon, 21 Sep 2015 17:40:05 +0200 From: Oleg Nesterov To: Vincent =?iso-8859-1?Q?Stehl=E9?= Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , trivial@kernel.org Subject: Re: [PATCH] fs/super.c: use && instead of & for warn_on condition Message-ID: <20150921154005.GA22742@redhat.com> References: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21, Vincent Stehlé wrote: > > --- a/fs/super.c > +++ b/fs/super.c > @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait) > else > ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1); > > - WARN_ON(force_trylock & !ret); > + WARN_ON(force_trylock && !ret); OOPS! yes, this is a typo, thanks! Harmless in this particular case, but still. Acked-by: Oleg Nesterov