Re: [PATCH 3/3] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Sep 21, 2015 at 04:27:28PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Sunday, September 20, 2015 10:29 PM
> > To: KY Srinivasan <kys@microsoft.com>
> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> > olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com;
> > jasowang@redhat.com; Jake Oshins <jakeo@microsoft.com>
> > Subject: Re: [PATCH 3/3] drivers:hv: Define the channel type for Hyper-V PCI
> > Express pass-through
> > 
> > On Tue, Sep 15, 2015 at 06:26:49PM -0700, K. Y. Srinivasan wrote:
> > > From: Jake Oshins <jakeo@microsoft.com>
> > >
> > > This defines the channel type for PCI front-ends in Hyper-V VMs.
> > >
> > > Signed-off-by: Jake Oshins <jakeo@microsoft.com>
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > ---
> > >  include/linux/hyperv.h |   11 +++++++++++
> > >  1 files changed, 11 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> > > index ea0a0e3..5587899 100644
> > > --- a/include/linux/hyperv.h
> > > +++ b/include/linux/hyperv.h
> > > @@ -1140,6 +1140,17 @@ u64 hv_do_hypercall(u64 control, void *input,
> > void *output);
> > >  		}
> > >
> > >  /*
> > > + * PCI Express Pass Through
> > > + * {44C4F61D-4444-4400-9D52-802E27EDE19F}
> > > + */
> > > +
> > > +#define HV_PCIE_GUID \
> > > +	.guid = { \
> > > +			0x1D, 0xF6, 0xC4, 0x44, 0x44, 0x44, 0x00, 0x44, \
> > > +			0x9D, 0x52, 0x80, 0x2E, 0x27, 0xED, 0xE1, 0x9F \
> > > +		}
> > > +
> > > +/*
> > >   * Common header for Hyper-V ICs
> > >   */
> > 
> > Yet you do nothing with this, so why add it to the code at this point in
> > time?  I can't take pointless things like this...
> 
> Greg,
> 
> This is a valid GUID that the host can offer us today. The driver to handle this is currently under review (Jake has
> posted the code). Traditionally, we have kept our header files in synch with the host functionality.

But please don't add things that are not used, that's pretty pointless.

Also wrap your email lines properly :)

thanks,

greg k-h