From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932242AbbIUVJq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Sep 2015 17:09:46 -0400
Received: from foss.arm.com ([217.140.101.70]:55201 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756201AbbIUVJn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Sep 2015 17:09:43 -0400
Date: Mon, 21 Sep 2015 22:09:38 +0100
From: Will Deacon <will.deacon@arm.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Riley Andrews <riandrews@android.com>, Shaohua Li <shli@kernel.org>,
        Shaohua Li <shaohua.li@fusionio.com>, Rik van Riel <riel@redhat.com>,
        Wu Fengguang <fengguang.wu@intel.com>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Dave P Martin <Dave.Martin@arm.com>,
        David Hildenbrand <dahi@linux.vnet.ibm.com>,
        James Morse <James.Morse@arm.com>, Mark Rutland <Mark.Rutland@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: ARM64 readahead: fault retry breaks mmap file read random
 detection
Message-ID: <20150921210938.GC7356@arm.com>
References: <1442868028-27055-1-git-send-email-salyzyn@android.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1442868028-27055-1-git-send-email-salyzyn@android.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 21, 2015 at 09:39:50PM +0100, Mark Salyzyn wrote:
> Description from commit 45cac65b0fcd
>     ("readahead: fault retry breaks mmap file read random detection")
> 
> .fault now can retry.  The retry can break state machine of .fault.  In
> filemap_fault, if page is miss, ra->mmap_miss is increased.  In the second
> try, since the page is in page cache now, ra->mmap_miss is decreased.  And
> these are done in one fault, so we can't detect random mmap file access.
> 
> Add a new flag to indicate .fault is tried once.  In the second try, skip
> ra->mmap_miss decreasing.  The filemap_fault state machine is ok with it.
> 
> I only tested x86, didn't test other archs, but looks the change for other
> archs is obvious, but who knows :)
> 
> < snip >
> 
> Yup, arm64 needs this too! Random read improves by 250%, sequential
> read improves by 40%, and random write by 400% to an eMMC device with
> dm crypto wrapped around it.

Thanks for this. This must've gone in whilst we were developing the initial
version of the arm64 port and has since gone unnoticed.

I'll queue it on the arm64 fixes branch and send a pull request after
some testing.

Will