From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933177AbbIUXHh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Sep 2015 19:07:37 -0400
Received: from mail-pa0-f44.google.com ([209.85.220.44]:34282 "EHLO
	mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756804AbbIUXHe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Sep 2015 19:07:34 -0400
Date: Tue, 22 Sep 2015 00:07:25 +0100
From: Lee Jones <lee.jones@linaro.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the
 TPS65912 PMIC
Message-ID: <20150921230725.GB11284@x1>
References: <1442339861-30300-1-git-send-email-afd@ti.com>
 <1442339861-30300-2-git-send-email-afd@ti.com>
 <20150920041630.GE3039@x1>
 <56003101.50107@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56003101.50107@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 21 Sep 2015, Andrew F. Davis wrote:
> On 09/19/2015 11:16 PM, Lee Jones wrote:
> >On Tue, 15 Sep 2015, Andrew F. Davis wrote:
> >
> >>The TPS65912 PMIC contains several regulators and a GPIO controller.
> >>Add bindings for the TPS65912 PMIC.
> >>
> >>Signed-off-by: Andrew F. Davis <afd@ti.com>
> >>---
> >>  .../devicetree/bindings/gpio/gpio-tps65912.txt     | 17 +++++++++
> >>  Documentation/devicetree/bindings/mfd/tps65912.txt | 43 ++++++++++++++++++++++
> >>  .../bindings/regulator/tps65912-regulator.txt      | 32 ++++++++++++++++
> >>  3 files changed, 92 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-tps65912.txt
> >>  create mode 100644 Documentation/devicetree/bindings/mfd/tps65912.txt
> >>  create mode 100644 Documentation/devicetree/bindings/regulator/tps65912-regulator.txt

[...]

> >>+Optional nodes:
> >>+ - Regulators: Documentation/devicetree/bindings/regulator/tps65912-regulator.txt
> >>+ - GPIO: Documentation/devicetree/bindings/gpio/gpio-tps65912.txt.
> >
> >Better to use ../gpio, ../regulator, etc.
> >
> >"Regulators" and "GPIO" aren't valid node names.
> >
> >Please be more specific.
> >
> 
> OK, I'll see if I can clear this up.

[...]

> >>+Optional properties:
> >>+ - Any optional property defined in bindings/regulator/regulator.txt
> >
> >../regulator/...
> >
> 
> Not really sure what you mean here?

Same as above.  Use "../regulator/regulator.txt" instead.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog