From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757448AbbIUXUe (ORCPT ); Mon, 21 Sep 2015 19:20:34 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33299 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755072AbbIUXUa (ORCPT ); Mon, 21 Sep 2015 19:20:30 -0400 Date: Tue, 22 Sep 2015 00:20:27 +0100 From: Lee Jones To: Sudeep Holla Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , "Rafael J. Wysocki" , Linus Walleij , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Message-ID: <20150921232027.GD11284@x1> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-18-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1442850433-5903-18-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Sep 2015, Sudeep Holla wrote: > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state, enable_irq_wake is recommended to be used for > the wakeup. > > This patch removes the use of IRQF_NO_SUSPEND flags replacing it with > enable_irq_wake instead. > > Cc: Linus Walleij > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Sudeep Holla > --- > drivers/mfd/ab8500-core.c | 11 +++++++++-- > drivers/mfd/ab8500-debugfs.c | 2 +- > drivers/mfd/ab8500-gpadc.c | 15 +++++++++++---- > drivers/mfd/db8500-prcmu.c | 24 +++++++++++++++++------- > drivers/power/ab8500_btemp.c | 6 ++++-- > drivers/power/ab8500_charger.c | 6 ++++-- > drivers/power/ab8500_fg.c | 9 ++++++--- > drivers/thermal/db8500_thermal.c | 5 ++--- > drivers/usb/phy/phy-ab8500-usb.c | 10 ++++++---- > 9 files changed, 60 insertions(+), 28 deletions(-) Is there a reason for bundling the changes in all of these subsystems together into a single patch? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog