From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476AbbIUXVl (ORCPT ); Mon, 21 Sep 2015 19:21:41 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33996 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753538AbbIUXVj (ORCPT ); Mon, 21 Sep 2015 19:21:39 -0400 Date: Tue, 22 Sep 2015 00:21:32 +0100 From: Lee Jones To: Sudeep Holla Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , "Rafael J. Wysocki" , Samuel Ortiz Subject: Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Message-ID: <20150921232132.GE11284@x1> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-8-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1442850433-5903-8-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The $SUBJECT is not correct. > The driver handles wakeup irq correctly using irq_set_irq_wake. There's > no need to use IRQF_NO_SUSPEND while registering the interrupt. > > This patch removes the use of IRQF_NO_SUSPEND flag. > > Cc: Samuel Ortiz > Cc: Lee Jones > Signed-off-by: Sudeep Holla > --- > drivers/mfd/qcom_rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ... code is fine though: Acked-by: Lee Jones Please re-submit with the subject line fixed. > diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c > index 6afc9fabd94c..207a3bd68559 100644 > --- a/drivers/mfd/qcom_rpm.c > +++ b/drivers/mfd/qcom_rpm.c > @@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev) > ret = devm_request_irq(&pdev->dev, > irq_ack, > qcom_rpm_ack_interrupt, > - IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND, > + IRQF_TRIGGER_RISING, > "qcom_rpm_ack", > rpm); > if (ret) { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog