From: Felipe Balbi <balbi@ti.com>
To: Felipe Tonello <eu@felipetonello.com>
Cc: USB list <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Peter Chen <Peter.Chen@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Subject: Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
Date: Mon, 21 Sep 2015 23:04:42 -0500 [thread overview]
Message-ID: <20150922040442.GH22310@saruman.tx.rr.com> (raw)
In-Reply-To: <CAGrhNMwaPWPHumpeJTuaThcvAkwkdcYJnYCGb0wNUj6gab19QQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
Hi,
On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote:
> Hi Balbi,
>
> On Fri, Sep 18, 2015 at 6:36 PM, <eu@felipetonello.com> wrote:
> > From: "Felipe F. Tonello" <eu@felipetonello.com>
> >
> > f_midi is not checking whether there is an error on usb_ep_queue
> > request, ignoring potential problems, such as memory leaks.
> >
> > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> > ---
> >
> > Changes for v2:
> > - Update code style.
> >
> > Changes for v3:
> > - Use ip_ep instead of out_ep. Fixed typo in commit message.
>
> I forgot to add v3 to the patch subject, so it queued here instead. Do
> you want me to re-send as v3?
you need to ask Peter, he's the chipidea maintainer. Peter ?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-22 4:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 17:36 [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
2015-09-21 9:21 ` Felipe Tonello
2015-09-22 4:04 ` Felipe Balbi [this message]
2015-09-22 5:39 ` Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2015-09-18 17:30 [PATCH 1/3] usb: chipidea: udc: _ep_queue and _hw_queue cleanup eu
2015-09-18 17:30 ` [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
2015-09-18 17:32 ` Felipe Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922040442.GH22310@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=Peter.Chen@freescale.com \
--cc=andrzej.p@samsung.com \
--cc=eu@felipetonello.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox