Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

Peter Chen
2015-09-22T06:52:42Z

On Mon, Sep 21, 2015 at 11:04:42PM -0500, Felipe Balbi wrote:
> Hi,
>
> On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote:
> > Hi Balbi,
> >
> > On Fri, Sep 18, 2015 at 6:36 PM, <eu@felipetonello.com> wrote:
> > > From: "Felipe F. Tonello" <eu@felipetonello.com>
> > >
> > > f_midi is not checking whether there is an error on usb_ep_queue
> > > request, ignoring potential problems, such as memory leaks.
> > >
> > > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> > > ---
> > >
> > > Changes for v2:
> > > - Update code style.
> > >
> > > Changes for v3:
> > > - Use ip_ep instead of out_ep. Fixed typo in commit message.
> >
> > I forgot to add v3 to the patch subject, so it queued here instead. Do
> > you want me to re-send as v3?
>
> you need to ask Peter, he's the chipidea maintainer. Peter ?
>

I have queued the first two for chipidea changes, the third one is
for gadget change.

--

Best Regards,
Peter Chen