From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daeseok Youn <daeseok.youn@gmail.com>,
driverdev-devel@linuxdriverproject.org,
Lidza Louina <lidza.louina@gmail.com>
Subject: Re: [PATCH] staging: dgap: fix returned errno code in dgap_parsefile()
Date: Tue, 22 Sep 2015 12:22:36 +0530 [thread overview]
Message-ID: <20150922065236.GB5526@sudip-pc> (raw)
In-Reply-To: <5600F773.5040208@osg.samsung.com>
On Tue, Sep 22, 2015 at 08:38:43AM +0200, Javier Martinez Canillas wrote:
> Hello Sudip,
>
> On 09/22/2015 06:52 AM, Sudip Mukherjee wrote:
> > On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
> >> The driver is using -1 instead of the -ENOMEM defined macro to specify
> >> that a buffer allocation failed. Since the error number is propagated,
> >> the caller will get a -EPERM which is the wrong error condition.
> > Just a little doubt. caller means the function which is calling this
> > dgap_parsefile() or you meant the user?
<snip>
>
> But I believe the patch and what the commit message says is true regardless
> of the fact that the caller is just checking for != 0. dgap_firmware_load()
> stills gets a wrong error condition whether it's checking it or not.
Yes. I just had a doubt what you meant by caller. If user then I would
have said that "patch is correct but commit message is not". :)
regards
sudip
prev parent reply other threads:[~2015-09-22 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 0:39 [PATCH] staging: dgap: fix returned errno code in dgap_parsefile() Javier Martinez Canillas
2015-09-22 4:52 ` Sudip Mukherjee
2015-09-22 6:38 ` Javier Martinez Canillas
2015-09-22 6:52 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922065236.GB5526@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox