From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757713AbbIVIKq (ORCPT ); Tue, 22 Sep 2015 04:10:46 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:42041 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757612AbbIVIKi (ORCPT ); Tue, 22 Sep 2015 04:10:38 -0400 Date: Tue, 22 Sep 2015 08:46:18 +0100 From: Charles Keepax To: Inha Song CC: , , , , , Subject: Re: [alsa-devel] [PATCH] mfd: arizona: Call the runtime PM function if the state is runtime resumed Message-ID: <20150922074618.GA11647@ck-lbox> References: <1442478527-29304-1-git-send-email-ideal.song@samsung.com> <20150917082542.GB7694@ck-lbox> <20150917180530.346232ce@songinha-Samsung-DeskTop-System> <20150917091632.GC7694@ck-lbox> <20150918154903.549cf6d0@songinha-Samsung-DeskTop-System> <20150918082446.GD7694@ck-lbox> <20150921111642.112dc0c2@songinha-Samsung-DeskTop-System> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150921111642.112dc0c2@songinha-Samsung-DeskTop-System> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-09-22_03:2015-09-22,2015-09-22,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1508030000 definitions=main-1509220137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 11:16:42AM +0900, Inha Song wrote: > Hi, Charles, > > I've already tried to change. > If I change to that, we can't enter the suspen during the playback. > > - > [ 72.538263] arizona spi1.0: Suspend, disabling IRQ > ... > [ 72.585823] arizona spi1.0: Late suspend, reengabling IRQ > [ 72.585904] arizona spi1.0: Early resume, disabling IRQ > ... > [ 72.646770] PM: noirq suspend of devices failed > <- because of "spi1.0" pm_wakeup_pending() in suspend_noirq() Ok this looks more reasonable, suspend should fail because we do have an IRQ waiting to be handled, so we shouldn't suspend. But you are saying this happens every time the CODEC goes to suspend, thus blocking the suspend from suspending? First step then would be to identify what IRQ is occurring, could you set LOG_DEVICE at the top of drivers/base/regmap/regmap.c to "spi1.0" and provide a log, so we can see what IRQ is being asserted from the CODEC. Thanks, Charles