From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Alexei Starovoitov <ast@plumgrid.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Borislav Petkov <bp@suse.de>, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>,
pi3orama@163.com
Subject: Re: [PATCH 5/8] tools build: Allow setting the feature detection user
Date: Tue, 22 Sep 2015 10:05:39 -0300 [thread overview]
Message-ID: <20150922130539.GE4186@kernel.org> (raw)
In-Reply-To: <20150922130242.GD4186@kernel.org>
Em Tue, Sep 22, 2015 at 10:02:42AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Sep 22, 2015 at 08:51:00AM +0200, Jiri Olsa escreveu:
> > On Mon, Sep 21, 2015 at 06:23:18PM -0300, Arnaldo Carvalho de Melo wrote:
> > one nit ;-)
>
> Good, at first I thought the mistake was more embarassing, like
> forgetting one real use of that file... Fixing it, thanks!
> > +++ b/tools/build/Makefile.feature
> > @@ -132,7 +132,7 @@ endif
> > # The $(feature_display) controls the default detection message
> > # output. It's set if:
> > # - detected features differes from stored features from
> > -# last build (in FEATURE-DUMP file)
> > +# last build (in FEATURE-DUMP$(FEATURE_USER) file)
> > # - one of the $(FEATURE_DISPLAY) is not detected
I changed it to:
# The $(feature_display) controls the default detection message
# output. It's set if:
# - detected features differes from stored features from
-# last build (in FEATURE-DUMP file)
+# last build (in $(FEATURE_DUMP_FILENAME) file)
# - one of the $(FEATURE_DISPLAY) is not detected
So that we take $(OUTPUT) into account as well :-)
- Arnaldo
next prev parent reply other threads:[~2015-09-22 13:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 21:23 [RFC 0/8] tools/build fixes related to eBPF support Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 1/8] perf probe: Fix a segfault when removing uprobe events Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 2/8] perf tools: Don't assume that the parser returns non empty evsel list Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 3/8] tools build: Fixup feature detection display function name Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 4/8] tools lib ebpf: Fix up FEATURE_{TESTS,DISPLAY} usage Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 5/8] tools build: Allow setting the feature detection user Arnaldo Carvalho de Melo
2015-09-22 6:51 ` Jiri Olsa
2015-09-22 13:02 ` Arnaldo Carvalho de Melo
2015-09-22 13:05 ` Arnaldo Carvalho de Melo [this message]
2015-09-21 21:23 ` [PATCH 6/8] tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 7/8] perf tools: Add include/err.h into MANIFEST Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 8/8] perf tools: Make perf depend on libbpf Arnaldo Carvalho de Melo
2015-09-22 7:02 ` Jiri Olsa
2015-09-22 13:12 ` Arnaldo Carvalho de Melo
2015-09-22 7:03 ` Jiri Olsa
2015-09-22 13:18 ` Arnaldo Carvalho de Melo
2015-09-22 13:31 ` Jiri Olsa
2015-09-22 13:40 ` Arnaldo Carvalho de Melo
2015-09-22 13:55 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922130539.GE4186@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ast@plumgrid.com \
--cc=bp@suse.de \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox