From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933374AbbIVNFp (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 09:05:45 -0400
Received: from mail.kernel.org ([198.145.29.136]:33214 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932886AbbIVNFo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 09:05:44 -0400
Date: Tue, 22 Sep 2015 10:05:39 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@plumgrid.com>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>,
        pi3orama@163.com
Subject: Re: [PATCH 5/8] tools build: Allow setting the feature detection user
Message-ID: <20150922130539.GE4186@kernel.org>
References: <1442870601-26004-1-git-send-email-acme@kernel.org>
 <1442870601-26004-6-git-send-email-acme@kernel.org>
 <20150922065100.GF29091@krava.redhat.com>
 <20150922130242.GD4186@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150922130242.GD4186@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Sep 22, 2015 at 10:02:42AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Sep 22, 2015 at 08:51:00AM +0200, Jiri Olsa escreveu:
> > On Mon, Sep 21, 2015 at 06:23:18PM -0300, Arnaldo Carvalho de Melo wrote:
> > one nit ;-) 
> 
> Good, at first I thought the mistake was more embarassing, like
> forgetting one real use of that file... Fixing it, thanks!

> > +++ b/tools/build/Makefile.feature
> > @@ -132,7 +132,7 @@ endif
> >  # The $(feature_display) controls the default detection message
> >  # output. It's set if:
> >  # - detected features differes from stored features from
> > -#   last build (in FEATURE-DUMP file)
> > +#   last build (in FEATURE-DUMP$(FEATURE_USER) file)
> >  # - one of the $(FEATURE_DISPLAY) is not detected

I changed it to:

 # The $(feature_display) controls the default detection message
 # output. It's set if:
 # - detected features differes from stored features from
-#   last build (in FEATURE-DUMP file)
+#   last build (in $(FEATURE_DUMP_FILENAME) file)
 # - one of the $(FEATURE_DISPLAY) is not detected

So that we take $(OUTPUT) into account as well :-)

- Arnaldo