From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
David Ahern <dsahern@gmail.com>, He Kuang <hekuang@huawei.com>,
Kaixu Xia <xiakaixu@huawei.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Zefan Li <lizefan@huawei.com>,
pi3orama@163.com
Subject: Re: [PATCH 8/8] perf tools: Make perf depend on libbpf
Date: Tue, 22 Sep 2015 10:12:32 -0300 [thread overview]
Message-ID: <20150922131232.GA10097@kernel.org> (raw)
In-Reply-To: <20150922070259.GG29091@krava.redhat.com>
Em Tue, Sep 22, 2015 at 09:02:59AM +0200, Jiri Olsa escreveu:
> On Mon, Sep 21, 2015 at 06:23:21PM -0300, Arnaldo Carvalho de Melo wrote:
>
> SNIP
>
> > + NO_LIBBPF := 1
> > else
> > ifneq ($(filter s% -static%,$(LDFLAGS),),)
> > msg := $(error No static glibc found, please install glibc-static);
> > @@ -309,6 +312,13 @@ ifndef NO_LIBELF
> > $(call detected,CONFIG_DWARF)
> > endif # PERF_HAVE_DWARF_REGS
> > endif # NO_DWARF
> > +
> > + ifndef NO_LIBBPF
> > + ifeq ($(feature-bpf), 1)
> > + CFLAGS += -DHAVE_LIBBPF_SUPPORT
> > + $(call detected,CONFIG_LIBBPF)
>
> what depends on CONFIG_LIBBPF ? I dont see any object being dependent on it
Nothing, as far as this patchkit goes, that is why I said this in the
cover letter:
---------------------------------------------------------------
The last one is not planned for my next perf/core pull req to
Ingo, still requires some more work, but is necessary so that we can
exercise the tools/build/ features fixed/introduced in this patchkit.
---------------------------------------------------------------
https://lkml.kernel.org/r/1442870601-26004-1-git-send-email-acme@kernel.org
- Arnaldo
next prev parent reply other threads:[~2015-09-22 13:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 21:23 [RFC 0/8] tools/build fixes related to eBPF support Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 1/8] perf probe: Fix a segfault when removing uprobe events Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 2/8] perf tools: Don't assume that the parser returns non empty evsel list Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 3/8] tools build: Fixup feature detection display function name Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 4/8] tools lib ebpf: Fix up FEATURE_{TESTS,DISPLAY} usage Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 5/8] tools build: Allow setting the feature detection user Arnaldo Carvalho de Melo
2015-09-22 6:51 ` Jiri Olsa
2015-09-22 13:02 ` Arnaldo Carvalho de Melo
2015-09-22 13:05 ` Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 6/8] tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 7/8] perf tools: Add include/err.h into MANIFEST Arnaldo Carvalho de Melo
2015-09-21 21:23 ` [PATCH 8/8] perf tools: Make perf depend on libbpf Arnaldo Carvalho de Melo
2015-09-22 7:02 ` Jiri Olsa
2015-09-22 13:12 ` Arnaldo Carvalho de Melo [this message]
2015-09-22 7:03 ` Jiri Olsa
2015-09-22 13:18 ` Arnaldo Carvalho de Melo
2015-09-22 13:31 ` Jiri Olsa
2015-09-22 13:40 ` Arnaldo Carvalho de Melo
2015-09-22 13:55 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922131232.GA10097@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=brendan.d.gregg@gmail.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox