From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757940AbbIVNMj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 09:12:39 -0400
Received: from mail.kernel.org ([198.145.29.136]:33795 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757845AbbIVNMg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 09:12:36 -0400
Date: Tue, 22 Sep 2015 10:12:32 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        David Ahern <dsahern@gmail.com>, He Kuang <hekuang@huawei.com>,
        Kaixu Xia <xiakaixu@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Zefan Li <lizefan@huawei.com>,
        pi3orama@163.com
Subject: Re: [PATCH 8/8] perf tools: Make perf depend on libbpf
Message-ID: <20150922131232.GA10097@kernel.org>
References: <1442870601-26004-1-git-send-email-acme@kernel.org>
 <1442870601-26004-9-git-send-email-acme@kernel.org>
 <20150922070259.GG29091@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150922070259.GG29091@krava.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Sep 22, 2015 at 09:02:59AM +0200, Jiri Olsa escreveu:
> On Mon, Sep 21, 2015 at 06:23:21PM -0300, Arnaldo Carvalho de Melo wrote:
> 
> SNIP
> 
> > +      NO_LIBBPF := 1
> >      else
> >        ifneq ($(filter s% -static%,$(LDFLAGS),),)
> >          msg := $(error No static glibc found, please install glibc-static);
> > @@ -309,6 +312,13 @@ ifndef NO_LIBELF
> >        $(call detected,CONFIG_DWARF)
> >      endif # PERF_HAVE_DWARF_REGS
> >    endif # NO_DWARF
> > +
> > +  ifndef NO_LIBBPF
> > +    ifeq ($(feature-bpf), 1)
> > +      CFLAGS += -DHAVE_LIBBPF_SUPPORT
> > +      $(call detected,CONFIG_LIBBPF)
> 
> what depends on CONFIG_LIBBPF ? I dont see any object being dependent on it

Nothing, as far as this patchkit goes, that is why I said this in the
cover letter:

---------------------------------------------------------------
	The last one is not planned for my next perf/core pull req to
Ingo, still requires some more work, but is necessary so that we can
exercise the tools/build/ features fixed/introduced in this patchkit.
---------------------------------------------------------------

https://lkml.kernel.org/r/1442870601-26004-1-git-send-email-acme@kernel.org

- Arnaldo