From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933405AbbIVN1W (ORCPT ); Tue, 22 Sep 2015 09:27:22 -0400 Received: from m12-12.163.com ([220.181.12.12]:42389 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757874AbbIVN1T (ORCPT ); Tue, 22 Sep 2015 09:27:19 -0400 Date: Tue, 22 Sep 2015 21:15:53 +0800 From: Yaowei Bai To: Michal Hocko Cc: akpm@linux-foundation.org, mgorman@suse.de, rientjes@google.com, hannes@cmpxchg.org, vdavydov@parallels.com, oleg@redhat.com, vbabka@suse.cz, iamjoonsoo.kim@lge.com, zhangyanfei@cn.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/vmscan: make inactive_anon_is_low_global return directly Message-ID: <20150922131553.GA4221@bbox> References: <1442404800-4051-1-git-send-email-bywxiaobai@163.com> <20150921161806.GE19811@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150921161806.GE19811@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-CM-TRANSID: DMCowECpLEuJVAFWwq+YBA--.82S3 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUVQzVUUUUU X-Originating-IP: [58.208.66.254] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiuw59T1O-wOAqbwAAsO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 06:18:07PM +0200, Michal Hocko wrote: > On Wed 16-09-15 19:59:58, Yaowei Bai wrote: > > Delete unnecessary if to let inactive_anon_is_low_global return > > directly. > > > > No functional changes. > > Is this really an improvement? I am not so sure. If anything the > function has a bool return semantic... Just FYI, I also sent a patch making inactive_anon_is_low_global return bool and it has been added into Andrew's -mm tree. >