From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757948AbbIVNZV (ORCPT ); Tue, 22 Sep 2015 09:25:21 -0400 Received: from m12-13.163.com ([220.181.12.13]:60459 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933589AbbIVNZR (ORCPT ); Tue, 22 Sep 2015 09:25:17 -0400 Date: Tue, 22 Sep 2015 21:22:57 +0800 From: Yaowei Bai To: Johannes Berg Cc: perex@perex.cz, tiwai@suse.com, k.kozlowski@samsung.com, elfring@users.sourceforge.net, fabf@skynet.be, lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool Message-ID: <20150922132257.GB4221@bbox> References: <1442843834-4648-1-git-send-email-bywxiaobai@163.com> <1442843834-4648-4-git-send-email-bywxiaobai@163.com> <1442844660.1876.2.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442844660.1876.2.camel@sipsolutions.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-CM-TRANSID: DcCowAD37R4xVgFWOwQ_Cg--.25915S3 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUTNeOUUUUU X-Originating-IP: [58.208.66.254] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiUBR9T1WBQOAdSQAAsW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote: > > > -static inline int prioq_match(struct snd_seq_event_cell *cell, > > +static inline bool prioq_match(struct snd_seq_event_cell *cell, > > int client, int timestamp) > > I think you should fix up the indentation now. Sorry, I'm quite a new guy to linux kernel. I think you mean this patch is not appropriate, right? > > johannes