From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756529AbbIVOEt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 10:04:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47213 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751244AbbIVOEr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 10:04:47 -0400
Date: Tue, 22 Sep 2015 11:04:43 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Kapileshwar Singh <kapileshwar.singh@arm.com>,
        linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
        Javi Merino <javi.merino@arm.com>, David Ahern <dsahern@gmail.com>,
        Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH v5] tools lib traceevent: str addresses in heterogeneous
 arch environments
Message-ID: <20150922140443.GC2580@redhat.com>
References: <1442928123-13824-1-git-send-email-kapileshwar.singh@arm.com>
 <20150922094618.2e730aa8@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150922094618.2e730aa8@gandalf.local.home>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Sep 22, 2015 at 09:46:18AM -0400, Steven Rostedt escreveu:
> On Tue, 22 Sep 2015 14:22:03 +0100
> Kapileshwar Singh <kapileshwar.singh@arm.com> wrote:
> 
> >  		if (!(field->flags & FIELD_IS_ARRAY) &&
> >  		    field->size == pevent->long_size) {
> > -			addr = *(unsigned long *)(data + field->offset);
> > +
> > +			/* Handle heterogeneous recording and processing
> > +			 * architectures
> > +			 *
> > +			 * CASE I:
> > +			 * Traces recorded on 32-bit devices (32-bit
> > +			 * addressing) and processed on 64-bit devices:
> > +			 * In this case, only 32 bits should be read.
> > +			 *
> > +			 * CASE II:
> > +			 * Traces recorded on 64 bit devices and processed
> > +			 * on 32-bit devices:
> > +			 * In this case, 64 bits must be read.
> 
> Probably should have added a comment about not caring about endianess
> and why, but that can be added later. This patch is good enough for now.
> 
> Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
> 
> Arnaldo, want to pick this up?

Sure, I'm adding it to perf/core, i.e. for 4.4, or do you think this
needs to go into 4.3?

- Arnaldo