From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754851AbbIVOXh (ORCPT ); Tue, 22 Sep 2015 10:23:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52239 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbbIVOXg (ORCPT ); Tue, 22 Sep 2015 10:23:36 -0400 Date: Tue, 22 Sep 2015 15:23:25 +0100 From: Aaron Tomlin To: Yaowei Bai Cc: akpm@linux-foundation.org, uobergfe@redhat.com, dzickus@redhat.com, cmetcalf@ezchip.com, fweisbec@gmail.com, eranian@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/watchdog: is_hardlockup can be boolean Message-ID: <20150922142325.GB25024@atomlin.usersys.redhat.com> References: <1442928763-4425-1-git-send-email-bywxiaobai@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7qSK/uQB79J36Y4o" Content-Disposition: inline In-Reply-To: <1442928763-4425-1-git-send-email-bywxiaobai@163.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7qSK/uQB79J36Y4o Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2015-09-22 21:32 +0800, Yaowei Bai wrote: > This patch makes is_hardlockup return bool to improve readability > due to this particular function only using either one or zero as its > return value. >=20 > No functional change. >=20 > Signed-off-by: Yaowei Bai > --- > kernel/watchdog.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > index 64ed1c3..568ba64 100644 > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -263,15 +263,15 @@ void touch_softlockup_watchdog_sync(void) > =20 > #ifdef CONFIG_HARDLOCKUP_DETECTOR > /* watchdog detector functions */ > -static int is_hardlockup(void) > +static bool is_hardlockup(void) > { > unsigned long hrint =3D __this_cpu_read(hrtimer_interrupts); > =20 > if (__this_cpu_read(hrtimer_interrupts_saved) =3D=3D hrint) > - return 1; > + return true; > =20 > __this_cpu_write(hrtimer_interrupts_saved, hrint); > - return 0; > + return false; > } > #endif > =20 Fair enough with regards to readability. Reviewed-by: Aaron Tomlin --7qSK/uQB79J36Y4o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWAWRdAAoJEOLellgZzHfWybsP/RVMh1i8SGWBXOHgulZ9GsGo dWz4f/AVxQ8HQp+3/445G4+p8C/PVywauL/oqShIoWXsdI0W4k/klqUJHDn78jh/ nRmvZKDsvw5g9ad1LGr2PBNVgbeg7UXOSdJG4ggl1zBoyucLGRmQOJFiqVWS4bu0 yL1MMSg/pnZx9/d9hzlY1KIweRkmIUulwwCIZ+6E3tpDj8yGpfg7Bn+MbrGudXn/ EwAO4Wnf8n1l7fVYxO/ORH7+LOUBXIY5Q/vBgVdFGmvExJ8mW9ThhnLh5dpN0rSL XqPHRzFVFGqvF43hvWYS1Pfg18dDE8fUG9EmTTHtcjAyMBY04gIh+7BdjVXPAq9L qY83vPk/yLgnJrSdFTd7FGOWVAb31Y9P99Y2+TlAknBtqMAvMj/L1f2SMAAH0oth ryspILcrMeSZc8cmNDG+MF7HXCY2rE9Ef5s5e+TiONbNSmIqJCr5JmQZ/idWWd0D epZXfCoKGkEtQP8wDVJd36jP3/lldvXcVJ1u0GRxs2sfawjwDXsdcoM9MLmE7xLQ eEqVcJGbKJzEvKprMIDPdV2u7ORTefqXu0K85l5RsqiqeOIVY4lMAR2uZZF2sRBt xUOhmUKtrz2WWe/0Pr+F0iMtALL5JTebX/x/RpjWBSttXQGahn9ZoQsePlYEuVST LdFeVHGU3OaeezYW98Gk =+WWN -----END PGP SIGNATURE----- --7qSK/uQB79J36Y4o--