From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758778AbbIVQve (ORCPT ); Tue, 22 Sep 2015 12:51:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51035 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757764AbbIVQv3 (ORCPT ); Tue, 22 Sep 2015 12:51:29 -0400 Date: Tue, 22 Sep 2015 09:51:27 -0700 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, Greg Kroah-Hartman , Len Brown , open list , Pavel Machek Subject: Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors Message-ID: <20150922165127.GH23081@codeaurora.org> References: <3ad0ce115028e628e556a505689d396b6e98f04e.1442939340.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ad0ce115028e628e556a505689d396b6e98f04e.1442939340.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22, Viresh Kumar wrote: > of_property_count_u32_elems() will never return 0, but a -ve error value > of a positive count. And so the current !count check is wrong. > > Also, a missing "opp-microvolt" property isn't a problem and so we need > to do of_find_property() separately to confirm that. > > Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings") > Signed-off-by: Viresh Kumar > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project