From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758453AbbIVReu (ORCPT ); Tue, 22 Sep 2015 13:34:50 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:46542 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751670AbbIVRes (ORCPT ); Tue, 22 Sep 2015 13:34:48 -0400 Date: Tue, 22 Sep 2015 19:12:29 +0200 From: Ralf Baechle To: Thomas Gleixner Cc: Alexander Couzens , linux-mips@linux-mips.org, Alban Bedel , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: ath79: add irq chip ar7240-misc-intc Message-ID: <20150922171228.GB18064@linux-mips.org> References: <1442636780-2891-1-git-send-email-lynxis@fe80.eu> <1442636780-2891-3-git-send-email-lynxis@fe80.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 12:24:26PM +0200, Thomas Gleixner wrote: > > The ar7240 misc irq chip use ack handler > > instead of ack_mask handler. All new ath79 chips use > > the ar7240 misc irq chip > > > > Signed-off-by: Alexander Couzens > > Acked-by: Alban Bedel > > --- > > .../interrupt-controller/qca,ath79-misc-intc.txt | 20 ++++++++++++++++++-- > > arch/mips/ath79/irq.c | 10 ++++++++++ > > That driver should probably move into drivers/irqchip. Like a fair number of other irq.c type files in arch/mips that could reasonably easily be rewritten to go to drivers/irqchip. > Other than that. > > Acked-by: Thomas Gleixner Thanks, I replaced the previous version of this patch with this one. Ralf