From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759508AbbIVSpl (ORCPT ); Tue, 22 Sep 2015 14:45:41 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:19047 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758230AbbIVSpf (ORCPT ); Tue, 22 Sep 2015 14:45:35 -0400 Date: Tue, 22 Sep 2015 21:45:18 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Lidza Louina , Mark Hounschell , Daeseok Youn , Greg Kroah-Hartman , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: dgap: remove unused variable Message-ID: <20150922184518.GF4953@mwanda> References: <1441886099-24399-1-git-send-email-sudipm.mukherjee@gmail.com> <1441886099-24399-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441886099-24399-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2015 at 05:24:59PM +0530, Sudip Mukherjee wrote: > Removed them but kept one call to ioread8() as it might affect the > hardware. Just leave the extra variable until someone has the hardware and can verify the right fix. Static checker warnings are good, don't silence them just to silence them. regards, dan carpenter