From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934257AbbIVSvH (ORCPT ); Tue, 22 Sep 2015 14:51:07 -0400 Received: from foss.arm.com ([217.140.101.70]:59850 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759333AbbIVSus (ORCPT ); Tue, 22 Sep 2015 14:50:48 -0400 Date: Tue, 22 Sep 2015 19:50:37 +0100 From: Marc Zyngier To: Yang Yingliang Cc: , , Jiang Liu , Thomas Gleixner , Mark Rutland , "Will Deacon" , Russell King - ARM Linux , Hanjun Guo Subject: Re: [RFC PATCH v5 4/4] arm: fix a migrating irq bug when hotplug cpu Message-ID: <20150922195037.472b404c@arm.com> In-Reply-To: <1442631959-10228-5-git-send-email-yangyingliang@huawei.com> References: <1442631959-10228-1-git-send-email-yangyingliang@huawei.com> <1442631959-10228-5-git-send-email-yangyingliang@huawei.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 19 Sep 2015 11:05:59 +0800 Yang Yingliang wrote: > When cpu is disabled, all irqs will be migratged to another cpu. > In some cases, a new affinity is different, it needed to be coppied > to irq's affinity. But if the type of irq is LPI, it's affinity will > not be coppied because of irq_set_affinity's return value. Fix it by > using irq_do_set_affinity. > > And migrating interrupts is a core code matter, so use the generic > function irq_migrate_all_off_this_cpu() to migrate interrupts in > kernel/irq/migration.c. > > Cc: Jiang Liu > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: Will Deacon > Cc: Russell King - ARM Linux > Cc: Hanjun Guo > Signed-off-by: Yang Yingliang Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.