From: Felipe Balbi <balbi@ti.com>
To: "Felipe F. Tonello" <eu@felipetonello.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Peter Chen <Peter.Chen@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Subject: Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails
Date: Tue, 22 Sep 2015 16:17:28 -0500 [thread overview]
Message-ID: <20150922211728.GF7094@saruman.tx.rr.com> (raw)
In-Reply-To: <1442948350-31702-3-git-send-email-eu@felipetonello.com>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Tue, Sep 22, 2015 at 07:59:10PM +0100, Felipe F. Tonello wrote:
> This fix a memory leak that will occur in this case.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
> drivers/usb/gadget/function/f_midi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index e92aff5..e6a114b 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -550,9 +550,11 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
> int err;
>
> err = usb_ep_queue(ep, req, GFP_ATOMIC);
> - if (err < 0)
> + if (err < 0) {
> ERROR(midi, "%s queue req: %d\n",
> midi->in_ep->name, err);
> + free_ep_req(ep, req);
sure this request won't be needed on the next time the tasklet is queued ?
Although, this looks correct, let's try to make sure really is correct.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-22 21:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 18:59 [PATCH 1/3] usb: chipidea: core: fix when building without CONFIG_PM support Felipe F. Tonello
2015-09-22 18:59 ` [PATCH 2/3] usb: gadget: f_midi: free usb request when done Felipe F. Tonello
2015-09-22 21:14 ` Felipe Balbi
2015-09-23 3:10 ` Peter Chen
2015-09-23 11:47 ` Felipe Tonello
2015-09-23 14:30 ` Alan Stern
2015-09-23 14:47 ` Felipe Tonello
2015-09-22 18:59 ` [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails Felipe F. Tonello
2015-09-22 21:17 ` Felipe Balbi [this message]
2015-09-23 7:09 ` Peter Chen
2015-09-23 11:40 ` Felipe Tonello
2015-09-24 1:20 ` Peter Chen
2015-09-25 8:27 ` Felipe Tonello
2015-09-25 9:02 ` Peter Chen
2015-09-25 10:25 ` Felipe Tonello
2015-09-22 21:12 ` [PATCH 1/3] usb: chipidea: core: fix when building without CONFIG_PM support Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922211728.GF7094@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=Peter.Chen@freescale.com \
--cc=andrzej.p@samsung.com \
--cc=eu@felipetonello.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox