From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760080AbbIWDIF (ORCPT ); Tue, 22 Sep 2015 23:08:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59760 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760017AbbIWDID (ORCPT ); Tue, 22 Sep 2015 23:08:03 -0400 Date: Tue, 22 Sep 2015 20:08:01 -0700 From: Greg KH To: "J. German Rivera" Cc: arnd@arndb.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, stuart.yoder@freescale.com, bhupesh.sharma@freescale.com, agraf@suse.de, bhamciu1@freescale.com, nir.erez@freescale.com, itai.katz@freescale.com, scottwood@freescale.com, leoli@freescale.com, R89243@freescale.com, dan.carpenter@oracle.com, richard.schmitt@freescale.com Subject: Re: [PATCH v2 3/6] staging: fsl-mc: up-rev dpbp binary interface to v2.0 Message-ID: <20150923030801.GA18243@kroah.com> References: <1442963339-32084-1-git-send-email-German.Rivera@freescale.com> <1442963339-32084-4-git-send-email-German.Rivera@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442963339-32084-4-git-send-email-German.Rivera@freescale.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 06:08:56PM -0500, J. German Rivera wrote: > Add cmd_flags parameter to all dpbp APIs to comply > with the dpbp 2.0 MC interface. Updated MC version > major number. Pass irq args in struct instead of > separate args. > > Signed-off-by: J. German Rivera > --- > drivers/staging/fsl-mc/bus/dpbp.c | 136 ++++++++++++++++++++---------- > drivers/staging/fsl-mc/include/dpbp-cmd.h | 2 +- > drivers/staging/fsl-mc/include/dpbp.h | 91 +++++++++++++++----- > 3 files changed, 162 insertions(+), 67 deletions(-) > > diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/staging/fsl-mc/bus/dpbp.c > index d99ab6d..0004e65 100644 > --- a/drivers/staging/fsl-mc/bus/dpbp.c > +++ b/drivers/staging/fsl-mc/bus/dpbp.c > @@ -34,14 +34,19 @@ > #include "../include/dpbp.h" > #include "../include/dpbp-cmd.h" > > -int dpbp_open(struct fsl_mc_io *mc_io, int dpbp_id, uint16_t *token) > +int dpbp_open(struct fsl_mc_io *mc_io, > + uint32_t cmd_flags, > + int dpbp_id, > + uint16_t *token) > { > struct mc_command cmd = { 0 }; > int err; > > /* prepare command */ > cmd.header = mc_encode_cmd_header(DPBP_CMDID_OPEN, > - MC_CMD_PRI_LOW, 0); > + cmd_flags, > + 0); Why are you reformatting all of these calls when you don't have to create a new line? Seems wasteful to me, as is: > + That empty line, why? thanks, greg k-h