From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752554AbbIWHJd (ORCPT ); Wed, 23 Sep 2015 03:09:33 -0400 Received: from mail-bn1bbn0105.outbound.protection.outlook.com ([157.56.111.105]:33871 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752411AbbIWHJa (ORCPT ); Wed, 23 Sep 2015 03:09:30 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=none action=none header.from=freescale.com; Date: Wed, 23 Sep 2015 15:09:18 +0800 From: Peter Chen To: "Felipe F. Tonello" CC: , , "Greg Kroah-Hartman" , Felipe Balbi , Andrzej Pietrasiewicz Subject: Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails Message-ID: <20150923070917.GA16159@shlinux2> References: <1442948350-31702-1-git-send-email-eu@felipetonello.com> <1442948350-31702-3-git-send-email-eu@felipetonello.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1442948350-31702-3-git-send-email-eu@felipetonello.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC009;1:2Cggp30J1tGv5uvHwAV9tey+5owmltd29zwfIlafFrA2CBynt8cQTvOHWFt+nFqR8CnCC9Zmgl9rHP14xmyvm/Nm4IixX5mIDmA8WB0EAIQZ3SIiqYeJrPrNkLdGCBG20RdXOoIM0UYqrra1Pg14boED5AyqANqL67EcPzdQyTaX58E2aIJWw84vE96phMjtFfy6vyyxY8rFb3ko+0oP43BSHa9PFtQwOZ3mk3nEcLPXEL3iDU/X5Lxh0zFWNt6y+9bTIjsBHDcOihnp+y/MtrjtNzItLuJUHFH3YLn6SgTqF6MlFX/Ii+tqlTAgBaZc6WoTfcLmR6dpE0sSRMYV1l7C4elWXFa8AITcKtqk6GSbfY+l+uOOGvNdYJCa/Eh2 X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(199003)(189002)(54356999)(76176999)(46406003)(50986999)(83506001)(19580405001)(19580395003)(46102003)(97756001)(85426001)(23726002)(87936001)(69596002)(33656002)(2950100001)(189998001)(4001350100001)(81156007)(97736004)(5001860100001)(5001830100001)(50466002)(62966003)(77096005)(33716001)(68736005)(106466001)(64706001)(105606002)(11100500001)(104016004)(47776003)(110136002)(92566002)(86362001)(5001960100002)(6806005)(5007970100001)(77156002)(4001540100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB484;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB484;2:5SrslLsypcEAIsiHzgRcBQZ04jtfGks31tRE7SedeygwoTcz4HjK7QZE9Yg9JcID56dzn5X4SfyMryhuxPf+2/zBEasKgYVRlndmBT/aNv3L6kNn0qLa/ABNp7ovDERKj3T/PzWpPTFWUiApg+9OcGCV45w0MX/Sr9NKzF3lt5k=;3:5S93FEpdHXQ83EMcggWXb3z39Nm+LJZvzm+J3i1KVY/lx5u/nSeAt1kVBPflmqSx423Kl7X9M47YMCN1j2cgwh9/eJRqLaNQOUFs9Q7SU7xXySPF9EeZ9VJJEjYaUQg10+okGn2CDOIbMC+twRqGqQeEyhModgklF5WjRwwDiSifbdKwH1aCzLiuNDG22Ot2+66PySZvmv1lWAMs6oR2Q4eORT5Fgz/SK8XHDvMInhw=;25:3D4ij2Pkmt2kRTxdbzrzsr/Yb1Fim2HeUYFVytDtr/ONnaWC0huklqKkHAxIE0cCjr3BTYDkpClBnvaF4ctIKuys/vTSMAp9f74qBeBusWR2922dTRQEmbRwBAL8EstzcVCxlZBTfrD4LXolkCmAvxSGZp13oZuOYhfsHcd/S8BimUwsuqbKP0+n/Ym1gdjtv+TsEufZMi2fG2baRXiTsdkrrHUnTEG0G/y36mdEaX7fooUv5q4OuJf+guH9YIqcPoRVJb10sXABTzwiNVeUFg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB484; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB484;20:9pCz5WeY42mfCOmGTFV2bmowbJFtimrW1l/OFC1cCNR2fzKBq4UXBfQuExGCvyZXnHBEjcQLvtc58jI9igKegoYNc6ORCtZV+9liu2nPKWP0mktKUp8nKkKm/gY0tGZkvJ3wQlgTb7pVN/2JgV8/F6AXlzC6PTociWc6Gn9N+Boy3auxgnOZu1UaYcrvc/92f25hPnYfwmtMJl/JqR8l6jCfC6sH4W1zP4lXazHwHOuaXK7SRxdi76yyAOl96qGBoRPkTw2iDjlk4Kohaj9OkKNsheoi53203tpHEZIYm7r9DZhIFQ+teWXHZeHEqQpqK8OTEws6BLbA8l8Swazps3TbnehPhIqW1olyO3QWVQw=;4:KEvn/YcifnzYB5TA15pBUA5eJ7hnkh8JprRZskXx6P/HRAmpvnGZsSTtVqZfpSg/toNMh952+f+HyipyyhdPWHEDf/pIJMigFX2siJ9BIdIpvUmPMk4YRnytyF81O4ctaaMSuwQLuLzIcpwLM6e5BDV/cPut35rivVcWMW/zNCEMLjqxVZGGRA9VMNliWvvd5sXhTwmhlFQSsi40xnlrBqLwJryqNbSZ9mTP0XzD0Qp394MAbfXXJ7uDhDL1uNa4xDGnn/QquWPHOCw06yttu3+BUq/n00Anx0K7zwI7RN5tiHxtx+3UKKE5aLZ55UcsKMy0QpaXXHEsQnTY1j2tNWZ3/v36kFB5wWG6KsCRLng= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BL2PR03MB484;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB484; X-Forefront-PRVS: 07083FF734 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB484;23:y2XaLKkFoHfQLD03rRARHsVDtcd/buxGLvC0FFSJYj?= =?us-ascii?Q?B/e9JtG++cUUl54QVTopP7wsLYNGBSgQM6i11dhrY3kzcUv1npNp/8VZvASN?= =?us-ascii?Q?rurLSgGxEwjUrPE9OnwBg92KSoTc22R3gzDd5yWuPJOfdH15Qlt4/tWKUnul?= =?us-ascii?Q?lrXk3BIaLcivMjjTOJflB1RkLFOR+HNbOthaRKPH3N6iu6ssy8T5gS+ADezH?= =?us-ascii?Q?fWaBrUHKVjEDmZ8C8M/MRNGUJadumyZV+TMQltKTTslIzD+xaT2WL7Ig/2fy?= =?us-ascii?Q?vkrNe/sVW13qoAWwsQlW8jvIQBab5nXZSdsDDsOVl0TQeqSzbHecMQl6YCF9?= =?us-ascii?Q?47/xyGOSf0ql4NhbvpeQGzPZhh32nIrBh9CNjR5mc3gtU5jmHfjours7G4CJ?= =?us-ascii?Q?RabvGUgdEMdozCVLadusJPjt9X6XQLUnZ/pD4npIP53N7d3YDp25tsjfJgCl?= =?us-ascii?Q?NKeuIBxOTl9wIey99RN+f7t9q64oWy+5zrPuiW9W4ee59QIGwYgZCR1ABOFE?= =?us-ascii?Q?n8qFVDg2RzCBcoE6jUEJeuP0gQlQdaGdYerNSnupZtm2rOgGkGSUK4euwK7d?= =?us-ascii?Q?UZ6sn83j9eERqgLbt+hk6tppRWc76/hrR4Jt1bD96JXDP+P1J47DmFt0dxaZ?= =?us-ascii?Q?sjI8qMIOET+H1AaGXR/L0iK+9dYQaiUNErr/QbIaXdS0XREK8Aax6Ca+EnOM?= =?us-ascii?Q?6IZYE+evTQEg4zye+4NwTVNRTqvRbnSIhsAi86HbfYWz82fO5qnbUBxEWf2d?= =?us-ascii?Q?C/u09PAjsz9715gpUAxx+CYmNA6WinDRwtxEJ+RaHrgb1gmNfP9FtHB9luOS?= =?us-ascii?Q?A8GcLzMh/VZuhuS73h+3SU0S6KVJj/RqBd7Nxvb3plKlxE8HJoxur+mRY39/?= =?us-ascii?Q?0jL+m7Ugo8GGRXePP5NsFj/QwGbmC8fkkk549eOQ/Pdp7Gf2jhUUTG3cMpUa?= =?us-ascii?Q?0CEp/jDA+mA/KzeIfHUaDAv2kF0XcCDmD4zUj4fY49goOva9+GeQEL3EMUdb?= =?us-ascii?Q?7Wzohjjsimvz7SZtno7y13LaHgpHIXra4HTc8Ep3hrD/k/kJ/mRvznZx36tf?= =?us-ascii?Q?n3HOWi9pMujkFI72BwFLIQRq3Ta9kyeD2DdymLKRlPgn+qaO0Dk85asl+RJ8?= =?us-ascii?Q?yZhFTxHwS8m7c5U8G/mGEvNcFr+0HthRWZ8WW9AGHYIECMJ4KVOiKN3M/SzX?= =?us-ascii?Q?9+aSaSAwyzkuY2cnaCD/Exkm/4DakgSjjYd1ZHfJv26vMkotnVJNL34TeAh0?= =?us-ascii?Q?WXMugtlp8zPZk5p2+2ZArUnd9VGfJbYHMCQwzn?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB484;5:FxI6VpjJE5FYCMw7JvWevadhPoLQCajH/VsTqaVAkSueenHiQmrr98HZ+Ps/LOTt/OeDtEMTLCNjsetTEdSEaYETiI7m4CHWANDABTq5ZF65ozi1ljERMlGoy2waGHdlCnmMgEm550yGf+vY9Xti9Q==;24:h9DTw61IY/MHRFj6YUNcGs874qxbU3ymTkmeMe8R/j27gx0qskMPJU6CfnCOu1NYMQmdCn1wrDSauVuuOliuUntiAEN6XIFxtG1WQpHIt/s=;20:+6RKRJ53wexXGw5RRHP9rEB9cjYoQ9U5Rq06ZzC6PYDbIXss2OUUTtmHxJoAmzpFzECFT/KQ3zfhjCjqcyKroQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2015 07:09:27.4381 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB484 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 07:59:10PM +0100, Felipe F. Tonello wrote: > This fix a memory leak that will occur in this case. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index e92aff5..e6a114b 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -550,9 +550,11 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req) > int err; > > err = usb_ep_queue(ep, req, GFP_ATOMIC); > - if (err < 0) > + if (err < 0) { > ERROR(midi, "%s queue req: %d\n", > midi->in_ep->name, err); > + free_ep_req(ep, req); > + } > } else { > free_ep_req(ep, req); > } > -- > 2.1.4 > I may know your problem, current midi library, alsa and this driver allow device sends as much data as possible, but without block the sending until host reads data, it only allocates the request buffer (using midi_alloc_ep_req), but without free, so after you send enough data, it is out of memory. -- Best Regards, Peter Chen