From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753225AbbIWIXK (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Sep 2015 04:23:10 -0400
Received: from mail-wi0-f172.google.com ([209.85.212.172]:36988 "EHLO
	mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751000AbbIWIXF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Sep 2015 04:23:05 -0400
Date: Wed, 23 Sep 2015 09:23:02 +0100
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Vinson Lee <vlee@twopensource.com>
Cc: rostedt@goodmis.org, Jiri Olsa <jolsa@kernel.org>,
        raphael.beamonte@gmail.com, "H. Peter Anvin" <hpa@zytor.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Namhyung Kim <namhyung@kernel.org>, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] tools lib api fs: Remove debugfs, tracefs and
 findfs objects
Message-ID: <20150923082302.GA2867@codeblueprint.co.uk>
References: <1441180605-24737-15-git-send-email-jolsa@kernel.org>
 <tip-60a1133a5b39738671eff1e4d77bedc1ee3fa528@git.kernel.org>
 <CAHTgTXWYbtd8B77dva2K=dHS1t-8nV7TtaEpoZFY87Q9XGTfBQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHTgTXWYbtd8B77dva2K=dHS1t-8nV7TtaEpoZFY87Q9XGTfBQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 21 Sep, at 05:20:03PM, Vinson Lee wrote:
> On Mon, Sep 14, 2015 at 11:59 PM, tip-bot for Jiri Olsa
> <tipbot@zytor.com> wrote:
> > Commit-ID:  60a1133a5b39738671eff1e4d77bedc1ee3fa528
> > Gitweb:     http://git.kernel.org/tip/60a1133a5b39738671eff1e4d77bedc1ee3fa528
> > Author:     Jiri Olsa <jolsa@kernel.org>
> > AuthorDate: Wed, 2 Sep 2015 09:56:44 +0200
> > Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
> > CommitDate: Mon, 14 Sep 2015 12:50:15 -0300
> >
> > tools lib api fs: Remove debugfs, tracefs and findfs objects
> >
> > We have all the functionality in fs.c, let's remove unneeded
> > objects.
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Matt Fleming <matt@codeblueprint.co.uk>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Raphael Beamonte <raphael.beamonte@gmail.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Link: http://lkml.kernel.org/r/1441180605-24737-15-git-send-email-jolsa@kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Hi.
> 
> This commit seems to have introduced a build failure with tools/vm.
> 
> $ make -C tools vm
> [...]
> gcc -Wall -Wextra -I../lib/ -o page-types page-types.c ../lib/api/libapi.a
> page-types.c:45:28: fatal error: api/fs/debugfs.h: No such file or directory
>  #include <api/fs/debugfs.h>

Given the ferocious pace of development of tools/perf, is there not
some kind of automated build that happens when new patches are picked
up, before they're pushed out?

Things are refactored and changed so fast in this area (I dare say
faster than almost any other part of the kernel source tree) that not
having the safety net of automated builds just seems suicidal.

And that doesn't even begin to cover runtime testing, since I've
noticed things breaking in tools/perf and people not catching it
immediately.

Does automated testing exist for perf tools development?

-- 
Matt Fleming, Intel Open Source Technology Center