From: Valentin Rothberg <valentinrothberg@gmail.com>
To: vbabka@suse.cz
Cc: rostedt@goodmis.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
ziegler@cs.fau.de, Paul Bolle <pebolle@tiscali.nl>
Subject: compaction.h: undefined CONFIG_ZONE_HIGHMEM_
Date: Wed, 23 Sep 2015 10:43:20 +0200 [thread overview]
Message-ID: <20150923084320.GA16863@ubuntu-vm> (raw)
Hi Vlastimil,
your commit 1434c81a47e3 ("mm, compaction: export tracepoints zone names
to userspace") has shown up in todays linux-next tree (i.e., 20150923)
adding the following lines of code:
--- a/include/trace/events/compaction.h
+++ b/include/trace/events/compaction.h
@@ -18,6 +18,31 @@
[...]
+#ifdef CONFIG_ZONE_HIGHMEM_
+#define IFDEF_ZONE_HIGHMEM(X) X
+#else
+#define IFDEF_ZONE_HIGHMEM(X)
+#endif
At the current state, the #ifdef block will not see a compiler since
CONFIG_ZONE_HIGHMEM_ is not defined anywhere. At first I thought it's a
typo as it ends with '_', but even ZONE_HIGHMEM isn't defined in
Kconfig. Is there a patch queued somewhere to fix the issue?
I detected the issue with undertaker-checkpatch from [1]. We run a bot
daily on linux-next to detect some Kconfig related issues and bugs.
Kind regards,
Valentin
[1] https://undertaker.cs.fau.de
next reply other threads:[~2015-09-23 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 8:43 Valentin Rothberg [this message]
2015-09-23 9:34 ` compaction.h: undefined CONFIG_ZONE_HIGHMEM_ Vlastimil Babka
2015-09-23 10:13 ` Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923084320.GA16863@ubuntu-vm \
--to=valentinrothberg@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pebolle@tiscali.nl \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=ziegler@cs.fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox