From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753607AbbIWJ1D (ORCPT ); Wed, 23 Sep 2015 05:27:03 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32320 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbbIWJ1A (ORCPT ); Wed, 23 Sep 2015 05:27:00 -0400 Date: Wed, 23 Sep 2015 12:26:36 +0300 From: Dan Carpenter To: "J. German Rivera" Cc: gregkh@linuxfoundation.org, arnd@arndb.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, stuart.yoder@freescale.com, itai.katz@freescale.com, leoli@freescale.com, scottwood@freescale.com, agraf@suse.de, bhamciu1@freescale.com, R89243@freescale.com, bhupesh.sharma@freescale.com, nir.erez@freescale.com, richard.schmitt@freescale.com Subject: Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0 Message-ID: <20150923092636.GV5004@mwanda> References: <1442963339-32084-1-git-send-email-German.Rivera@freescale.com> <1442963339-32084-7-git-send-email-German.Rivera@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442963339-32084-7-git-send-email-German.Rivera@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote: > /** > + * dprc_set_obj_label() - Set object label. > + * @mc_io: Pointer to MC portal's I/O object > + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_' > + * @token: Token of DPRC object > + * @obj_type: Object's type > + * @obj_id: Object's ID > + * @label: The required label. The maximum length is 16 chars. > + * > + * Return: '0' on Success; Error code otherwise. > + */ > +int dprc_set_obj_label(struct fsl_mc_io *mc_io, > + uint32_t cmd_flags, > + uint16_t token, > + char *obj_type, > + int obj_id, > + char *label); You can fix it in a later patch, but this documentation belongs in the .c file instead of the .h file. regards, dan carpenter