From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755071AbbIWNal (ORCPT ); Wed, 23 Sep 2015 09:30:41 -0400 Received: from m12-15.163.com ([220.181.12.15]:33349 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754856AbbIWNaj (ORCPT ); Wed, 23 Sep 2015 09:30:39 -0400 Date: Wed, 23 Sep 2015 21:29:03 +0800 From: Yaowei Bai To: Johannes Berg Cc: perex@perex.cz, tiwai@suse.com, k.kozlowski@samsung.com, elfring@users.sourceforge.net, fabf@skynet.be, lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool Message-ID: <20150923132902.GA4286@bbox> References: <1442843834-4648-1-git-send-email-bywxiaobai@163.com> <1442843834-4648-4-git-send-email-bywxiaobai@163.com> <1442844660.1876.2.camel@sipsolutions.net> <20150922132257.GB4221@bbox> <1442928492.2018.9.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442928492.2018.9.camel@sipsolutions.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-CM-TRANSID: D8CowECJLU4eqQJWYI3oBA--.23146S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XrWktFWfAF4rJF1kAryUtrb_yoWxurbEvr 17Cw4kCwsxKF1xCwsxKr1avFZFqr1DW3s3GwsYqrZrZa48Za45ArWDtr97Ja1YgF4xtF9x Krn5XF4F9r1agjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0NyCJUUUUU== X-Originating-IP: [58.208.66.158] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiLQJ+T1SIKaQNHgAAsc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 03:28:12PM +0200, Johannes Berg wrote: > On Tue, 2015-09-22 at 21:22 +0800, Yaowei Bai wrote: > > On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote: > > > > > > > -static inline int prioq_match(struct snd_seq_event_cell *cell, > > > > +static inline bool prioq_match(struct snd_seq_event_cell *cell, > > > > int client, int timestamp) > > > > > > I think you should fix up the indentation now. > > > > Sorry, I'm quite a new guy to linux kernel. I think you mean this > > patch is not appropriate, right? > > > > No, the change itself is fine, but you should fix the indentation there > so it lines up properly after your change. OK, will send it ASAP. Thanks. > > johannes