From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755130AbbIWONL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Sep 2015 10:13:11 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:48618 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755019AbbIWONJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Sep 2015 10:13:09 -0400
Date: Wed, 23 Sep 2015 17:11:06 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pavel Machek <pavel@denx.de>
Cc: Josh Cartwright <joshc@ni.com>, mark.rutland@arm.com,
        linux-doc@vger.kernel.org, rubini@gnudd.com,
        pantelis.antoniou@konsulko.com, hpa@zytor.com,
        s.trumtrar@pengutronix.de, devel@driverdev.osuosl.org,
        sameo@linux.intel.com, nico@linaro.org, ijc+devicetree@hellion.org.uk,
        michal.simek@xilinx.com, kyle.teske@ni.com,
        jgunthorpe@obsidianresearch.com, grant.likely@linaro.org,
        davidb@codeaurora.org, linus.walleij@linaro.org, cesarb@cesarb.net,
        devicetree@vger.kernel.org, jason@lakedaemon.net, pawel.moll@arm.com,
        iws@ovro.caltech.edu, atull@opensource.altera.com, broonie@kernel.org,
        philip@balister.org, Petr Cvek <petr.cvek@tul.cz>,
        dinguyen@opensource.altera.com, monstr@monstr.eu,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, balbi@ti.com,
        delicious.quinoa@gmail.com, robh+dt@kernel.org, rob@landley.net,
        galak@codeaurora.org, akpm@linux-foundation.org, davem@davemloft.net,
        m.chehab@samsung.com
Subject: Re: [PATCH v11 3/4] add FPGA manager core
Message-ID: <20150923141106.GH4953@mwanda>
References: <1442935271-10375-1-git-send-email-atull@opensource.altera.com>
 <1442935271-10375-4-git-send-email-atull@opensource.altera.com>
 <20150922222929.GA26335@jcartwri.amer.corp.natinst.com>
 <20150923132354.GB31253@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150923132354.GB31253@amd>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 23, 2015 at 03:23:54PM +0200, Pavel Machek wrote:
> > > +int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags,
> > > +			   const char *image_name)
> > > +{
> > > +	struct device *dev = &mgr->dev;
> > > +	const struct firmware *fw;
> > > +	int ret;
> > > +
> > > +	if (!mgr)
> > > +		return -ENODEV;
> > 
> > Again; I'm of the opinion this is needlessly defensive.
> 
> Not only that, it can never happen. mgr is already dereferenced above.
> 

It's not dereferenced.  We're taking the address of mgr->dev but we
don't dereference mgr.

regards,
dan carpenter