From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753679AbbIWR7p (ORCPT ); Wed, 23 Sep 2015 13:59:45 -0400 Received: from foss.arm.com ([217.140.101.70]:35330 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbbIWR7n (ORCPT ); Wed, 23 Sep 2015 13:59:43 -0400 Date: Wed, 23 Sep 2015 18:59:40 +0100 From: Will Deacon To: David Daney Cc: "linux-kernel@vger.kernel.org" , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Marc Zyngier , David Daney Subject: Re: [PATCH v2 2/5] PCI: generic: Only fixup irqs for bus we are creating. Message-ID: <20150923175940.GU7356@arm.com> References: <1442527332-1174-1-git-send-email-ddaney.cavm@gmail.com> <1442527332-1174-3-git-send-email-ddaney.cavm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442527332-1174-3-git-send-email-ddaney.cavm@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 11:02:09PM +0100, David Daney wrote: > From: David Daney > > If we create multiple buses with pci-host-generic, or there are buses > created by other drivers, we don't want to call pci_fixup_irqs() which > operates on all devices, not just the devices on the bus being added. > The consequence is that either the fixups are done more than once, or > in some cases incorrect fixups could be applied. > > Call pci_bus_fixup_irqs() instead of pci_fixup_irqs(). > > Signed-off-by: David Daney > --- > Changes from v1: Moved most of the code to pci_bus_fixup_irqs(), > making this patch very simple. Acked-by: Will Deacon Will