From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbbIXBRf (ORCPT ); Wed, 23 Sep 2015 21:17:35 -0400 Received: from mail-bn1on0118.outbound.protection.outlook.com ([157.56.110.118]:22154 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755739AbbIXBRb (ORCPT ); Wed, 23 Sep 2015 21:17:31 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=none action=none header.from=freescale.com; Date: Thu, 24 Sep 2015 09:17:16 +0800 From: Peter Chen To: "Felipe F. Tonello" CC: , , "Greg Kroah-Hartman" , Felipe Balbi , Andrzej Pietrasiewicz Subject: Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support Message-ID: <20150924011715.GA10369@shlinux2> References: <1443009418-29032-1-git-send-email-eu@felipetonello.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1443009418-29032-1-git-send-email-eu@felipetonello.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD056;1:aATwOVavTG+O61fzzpyrjqNp5DAleHAQiBX5xUZeRot3hVVS8GF5Ztusp5aq4/QFLAp3ecQDTetMtANt8AZST+omucGE6bezoDBSbW3YaOdmp8bpil43vqNhSx1WoKgfDo8qw3xvjsPc+QWAhCXRYWpM6L4Lmr5B2yqEPyXOBSvHL/CCdtt5FaQYmjHP+zYXNLd5sraN6P4j1ojU6Unmv1GbH9cJ8oXtozp2Z8xMYyyGfeFCkJpgwspzy/659/xaJgZlHZzrzU7wizzS0kPZbEHgc8/KrokR65BJBw8mYTkExSeY9f01pHhcI9X0KdG1vbXc8RpaHcWYaynfTM5RzmXNlbE46jf/q9iSedoFRSstGQeDeLtc3imPfYA3VmQG X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(24454002)(199003)(46406003)(97736004)(5001860100001)(86362001)(5007970100001)(23726002)(4001350100001)(4001540100001)(81156007)(5001830100001)(19580405001)(6806005)(104016004)(19580395003)(105606002)(33716001)(106466001)(87936001)(92566002)(46102003)(50466002)(77096005)(77156002)(11100500001)(83506001)(110136002)(189998001)(64706001)(97756001)(5001960100002)(54356999)(47776003)(33656002)(85426001)(50986999)(68736005)(2950100001)(76176999)(62966003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB1279;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1279;2:Y3OLu6O0G5sv7iowtxtEGf79ULlgGGdSCkD432KnKNKKR9Qck1eIGHDoNJTZoeg1fr+QZCn3vafpy5CyIjRc7WhVeIhX+6gpwZG9+51ulyY9x9/FGvOEONu2uUA3o3YRJIN22fQi5rikhw/T5oB9iK2G95XBymqeg4GJvHloh90=;3:MAM8pjm1dENCSxWUW58rYvTJw9QKvePhLzpJBcFkh7i9c2N0P+d+T8vGvLPfIODZsgfS50Z34NVu6VlBHvNLYHbnykvoYdwrKwox8o7ygsyUW0F+nbX0oHltDdbtykues4WGes2/qVgn0aWFIzurtEN2CWMpTBrA9chEclhLVdbmjICvzVB+I9csmsqGXvuHSAIBX+A8Kw/5Aai36MS3pcUratIUYEjQoBHqnjbaNj8=;25:9SIJIa+ytsLiP4ST4J3QOru3/bcsmpXO9PCOPHIfYShs/fl/Zto8MMbJdPH7ZVwwBIlqUBrPCW/Zuo0jDtCozHzNK9DVx77QXFTFW4Zs3IxOCKScp0F2YUMEPwFdp+viTEzHmfo9tzPUPLjqnAkHYdV2HCgmfVOVLBbQI5v1Yd2rDTbwbrkGqYSy69r1zExglbaul8qjQwWKZQvGbqVhj/n+Nlnghl6eUqupsBIMaO4AVQVT4guGa0n0MZ4wzMUTTj/PH2iAJsS+yme+eiSoVw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1279; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1279;20:V+n/qlC9QTT7WzmB/opr38O889Bf9f5Dp4NdR9gsTrpLxHBxmqo8ju8J8BUQtrONKuHOqegwdfNzpYmueQBHiRdKufdE+SrUfRtUp5DY8/whlVA2QWaq0EEzPrCf76+UwaWZPqjiC9Eya1hbqwp6FBTCC59RCdYyypNy9YhVs99EYswx+3xyL1e7sDx9N8dJHCJnJVAjc+XwgqYdDBA5H7cXeSCIehbZF4cO7IzGwUwxfo9d6ZK6aw5/evpwEksOIDI6mo5h3B9L5MBlC8aRxoD1nQW1MY5u7Jm0ZTQE77l/rzoWnPGW5ZrZrFyv/eXxZYHZXXYZEdxLik6X1K3hic5RysBrwoEqKd3+VpmS3us=;4:xIIUEjMidljFk2WXkndNbvMfBWnmuyGc0nTtp1M1hazqyUkxMbKtxM/Qbh51vOEnikNWkdlxu3u5jjcJNGVzAdiPs2Nq8QxbNICxwbch7gqDEWqMI4fHJz20K9xWfX/90H53rJ6Lu2xmXfqyYuOI7xPRgBtkunMksTrkVLY3puL3Tv0LRvu/YaFE10RZFGZscxJMajUC13ZhJzu6PPPXzGfsT+C8jZ/xZiqSeZ2Ws85zQsuJGelcLYwB3qe4kwDd5pTzgHwtoXHRCoCIHTGlECWEGz71EBWy7Qo8/U/Ys7883dWrp/Kuzr9QmM3YCQJNlUBxzEbfamxnQ+J4gAPXKJiaETZTSuy7PGd/WMC3nRo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:DM2PR0301MB1279;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1279; X-Forefront-PRVS: 070912876F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR0301MB1279;23:5B9HvxW0mB3cMcnq9bXAq5vdhYCxvdaxB5zEQQv?= =?us-ascii?Q?CH5rKspZ6OZoE9cDLhLLoOUZQ4il0npB++Bp13g8xkf2u8FNpJr/Fkg5ZlP7?= =?us-ascii?Q?8ImiPyajDspklPxnXhlikCVWbtO1ywxQL3wNjG1PG9ri594eY5nAYqizq997?= =?us-ascii?Q?5lVQ4mLOQ77OMvhIN0VXLAXRlSVebUUA2TvDErKs9iPLpcj3GDDye4BBTQwg?= =?us-ascii?Q?3V6yuDd1vLNMSSKkIM3MlH9G6C21ccTl6v+8V1SzzQ56tpKgcr2MwE+3QGrg?= =?us-ascii?Q?GIGPCJ95rXR1exOYUo1Igd4dpLriGP5HmADWTt2mIqLGX81JddC0E6W0HyY3?= =?us-ascii?Q?vw5gC1WRj4zRtyb/d5sRAa8nHL8Uyyqq1Rr9WWUDGHBEr51+qoNVklGBHgQM?= =?us-ascii?Q?HsU4y1X/u6t7+uyxBDwe7e2XlJd9NECg4mL22b2RUAxLpVejiLah+a79ePNr?= =?us-ascii?Q?zLXN48J3DRFNvAmWEGzekQGEiClUc/UOcdgC+Cq8qsO6zuVkemEFJkE5z4t1?= =?us-ascii?Q?ekZCuMMY/00rtJ/oGFlzjHkERTczxMqhAm29162UZRPQRWbdtfnT0iXmqYWB?= =?us-ascii?Q?g0lFN2D+p5bewoDvhd3wwngDjvXL0/2LNwGgL2CU5GDeEz4/b972V/JL5UJb?= =?us-ascii?Q?dLi+kdMNuo4hL0NWWWDzgRQzuv6hkNmYv5Ip+IEVrfYFMCCPShwjFBRhGpPD?= =?us-ascii?Q?YuGv2qb3PA1K4yq63QHf8i+ttgob0qgOCpuZ2DQ2WKglmGxabDf/V3QzXlHS?= =?us-ascii?Q?p/HZvsXaJonHCW65pwjd1Lptcjaomx34nTAZPQHytB68u3WHRftW+LIiHmNO?= =?us-ascii?Q?uUuZHYkGL1lVRe6fjK5EMbSnKqW6VxVk9mE5C43dSLGBz4aoOtTk/odRdQtS?= =?us-ascii?Q?3As7kAOf9ekLxpgnmDiZmks3cTCQU6c2CFaxI6SqDzUaFiow9mBxaYtCXzSX?= =?us-ascii?Q?Aj3MqoEzi4iBzSKaPw9sF9q0k68hIkA/6ajkaitst9K08rmh5aT7LdVXw8Qx?= =?us-ascii?Q?T2PLbUDGVNS5LS2Akc8E7Wbjiig0rz2WzTWCnXTKwrbCTRUDKbYlzAc+otuV?= =?us-ascii?Q?p5zwNabxIokYCbs8Dik/CWmICxOCQdsMT7a93UzYQUDwweaVHoobsbGh8Zv/?= =?us-ascii?Q?iYRx71YIUfn9mTuHAGDCLe7xkH9rB778NQC7HBMM4USRKvq/p2WRle8rbTGy?= =?us-ascii?Q?EtCTiYiDg0GIferqnIau4DSKu5kprL79f+jbcP3d6O0v+CDRx2KoRGn001Dt?= =?us-ascii?Q?urATMvyNsD0BJiy3MlJk=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1279;5:hUIWRIPP1v7BPLQKwRqDmDYLXgZ8jtQBqUhOtLm0xqwr170JgYoHXYfznmhs2FytBDuworVPZuidMmmsvvoZoadwD7H44vEAgwjnRjH/0K1Eev1yN2zjJEocM8d4I6R0Nsqm0GtI1rOYHUsKt8sIqw==;24:1X88iphnvqAbKkx+aTQlZqW3+HM2n3Jq5HJd7tQzzDzuUNPU8+pD/mtp70f4n7lp+llfMX4+HItq47Fpqd/NlECr7vf91hEdBLfOWG6mTRI=;20:W7sRMD1Wwa5+SI7SwMbxbOFl3NKxSLhTqUTdnDdYxjjRpHNzYBQr9dBlquBgLcVFo6zEsbDLWeCtJKUIvjgPtA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2015 01:17:28.5564 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1279 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote: > If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile > properly. > Would you post the warning or error messages? I just tried at v4.3-rc1 (v4.2 should be same), without any problems. Peter > Signed-off-by: Felipe F. Tonello > --- > > Changes for v2: > * removed unnecessary #ifdef CONFIG_PM_SLEEP. > > drivers/usb/chipidea/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 3ad48e1..382b4af 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -1009,18 +1009,20 @@ static int ci_runtime_resume(struct device *dev) > return ci_controller_resume(dev); > } > > -#endif /* CONFIG_PM */ > static const struct dev_pm_ops ci_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(ci_suspend, ci_resume) > SET_RUNTIME_PM_OPS(ci_runtime_suspend, ci_runtime_resume, NULL) > }; > +#endif /* CONFIG_PM */ > > static struct platform_driver ci_hdrc_driver = { > .probe = ci_hdrc_probe, > .remove = ci_hdrc_remove, > .driver = { > .name = "ci_hdrc", > +#ifdef CONFIG_PM > .pm = &ci_pm_ops, > +#endif > }, > }; > > -- > 2.1.4 > -- Best Regards, Peter Chen