From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751547AbbIXEqI (ORCPT ); Thu, 24 Sep 2015 00:46:08 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:38722 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbbIXEqC (ORCPT ); Thu, 24 Sep 2015 00:46:02 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 23 Sep 2015 21:45:53 -0700 From: "Paul E. McKenney" To: Patrick Marlier Cc: Steven Rostedt , NeilBrown , linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, wangyun@linux.vnet.ibm.com Subject: Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage Message-ID: <20150924044552.GG4029@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20150513125839.371ef677@notabene.brown> <5557819E.1060001@gmail.com> <20150518120647.0c3cecd8@notabene.brown> <20150518094321.2012a66a@gandalf.local.home> <20150519220725.GA6776@linux.vnet.ibm.com> <20150911230554.GA26655@linux.vnet.ibm.com> <55F54AA9.3020102@gmail.com> <20150913161023.GM4029@linux.vnet.ibm.com> <20150922205000.GA29408@linux.vnet.ibm.com> <5602E821.800@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5602E821.800@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15092404-0025-0000-0000-00001D5A82CD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2015 at 07:57:53PM +0200, Patrick Marlier wrote: > > On 09/22/2015 10:50 PM, Paul E. McKenney wrote: > >On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote: > >>On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote: > > > >[ . . . ] > > > >>>Paul, > >>> > >>>This sounds good to me. It should fix the performance issue (will > >>>check with my benchmark). > >> > >>Thank you, looking forward to seeing the results! > > > >Just following up -- how is the benchmarking going? > > Note that in my module I am using the kernel version 3.16.0-31 (I > ported your change). > Here the results of my benchmark that tests rculist in the case of > read only. > > # 1st column : The number of threads > # 2nd : ops/s the original version > # 3rd : ops/s your version with lockless_dereference > 1 883923 1747554 > 2 1741441 3543062 > 3 2462360 5103647 > 4 3437273 7176608 > 6 5155803 9812348 > 8 6718111 13330050 > 10 8519227 17458294 > 12 9773632 20298897 > 14 11555198 23191424 > 16 11643264 25125712 > > I get same performance with my patch. > So indeed it fixes the performance problem I was seeing. Nice, thank you!!! Thanx, Paul