public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments
@ 2015-09-23 19:52 Punit Vara
  2015-09-24  5:55 ` Sudip Mukherjee
  0 siblings, 1 reply; 3+ messages in thread
From: Punit Vara @ 2015-09-23 19:52 UTC (permalink / raw)
  To: Larry.Finger
  Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, Punit Vara

This patch is to the rtl871x_io.h file that fixes up following warning
reported by checkpatch.pl :

Signed-off-by: Punit Vara <punitvara@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_io.h | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_io.h b/drivers/staging/rtl8712/rtl871x_io.h
index 070cc03..9313943 100644
--- a/drivers/staging/rtl8712/rtl871x_io.h
+++ b/drivers/staging/rtl8712/rtl871x_io.h
@@ -48,10 +48,9 @@
 #define _IO_SYNC_		BIT(13)
 #define _IO_CMDMASK_	(0x1F80)
 
-/*
-	For prompt mode accessing, caller shall free io_req
-	Otherwise, io_handler will free io_req
-*/
+/* For prompt mode accessing, caller shall free io_req
+ * Otherwise, io_handler will free io_req
+ */
 /* IO STATUS TYPE */
 #define _IO_ERR_		BIT(2)
 #define _IO_SUCCESS_	BIT(1)
@@ -68,9 +67,7 @@
 #define IO_WR32_ASYNC	(_IO_WRITE_ | _IO_WORD_)
 #define IO_WR16_ASYNC	(_IO_WRITE_ | _IO_HW_)
 #define IO_WR8_ASYNC	(_IO_WRITE_ | _IO_BYTE_)
-/*
-	Only Sync. burst accessing is provided.
-*/
+/* Only Sync. burst accessing is provided.*/
 #define IO_WR_BURST(x)		(IO_WRITE_ | _IO_SYNC_ | _IO_BURST_ | \
 				((x) & _IOSZ_MASK_))
 #define IO_RD_BURST(x)		(_IO_SYNC_ | _IO_BURST_ | ((x) & _IOSZ_MASK_))
@@ -217,9 +214,7 @@ struct reg_protocol_wt {
 #endif
 };
 
-/*
-Below is the data structure used by _io_handler
-*/
+/* Below is the data structure used by _io_handler */
 
 struct io_queue {
 	spinlock_t lock;
-- 
2.5.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments
  2015-09-23 19:52 [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments Punit Vara
@ 2015-09-24  5:55 ` Sudip Mukherjee
  2015-09-24 16:29   ` punit vara
  0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-09-24  5:55 UTC (permalink / raw)
  To: Punit Vara
  Cc: Larry.Finger, devel, florian.c.schilhabel, linux-kernel, gregkh

On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote:
> This patch is to the rtl871x_io.h file that fixes up following warning
> reported by checkpatch.pl :
> 
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
You missed copying the warning after mentioning "following warning" in
your commit message.

regards
sudip

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments
  2015-09-24  5:55 ` Sudip Mukherjee
@ 2015-09-24 16:29   ` punit vara
  0 siblings, 0 replies; 3+ messages in thread
From: punit vara @ 2015-09-24 16:29 UTC (permalink / raw)
  To: Sudip Mukherjee; +Cc: Larry.Finger, devel, Flo Schil, linux-kernel, Greg KH

On Thu, Sep 24, 2015 at 11:25 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote:
>> This patch is to the rtl871x_io.h file that fixes up following warning
>> reported by checkpatch.pl :
>>
>> Signed-off-by: Punit Vara <punitvara@gmail.com>
>> ---
> You missed copying the warning after mentioning "following warning" in
> your commit message.
>
> regards
> sudip


Surely I will resend it .First let Greg say whether I have to send in
series or is it okay as it is. This was first time I have tried to fix
so many warnings in different problems. Whatever patch having issues I
would be happy to resend.
Thank you for feedback and evaluation.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-24 16:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-23 19:52 [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments Punit Vara
2015-09-24  5:55 ` Sudip Mukherjee
2015-09-24 16:29   ` punit vara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox