From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbbIXJKy (ORCPT ); Thu, 24 Sep 2015 05:10:54 -0400 Received: from mail-bl2on0113.outbound.protection.outlook.com ([65.55.169.113]:2007 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750704AbbIXJKv (ORCPT ); Thu, 24 Sep 2015 05:10:51 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=freescale.com; Date: Thu, 24 Sep 2015 17:10:35 +0800 From: Peter Chen To: Subbaraya Sundeep Bhatta CC: , , , , , , , "Subbaraya Sundeep Bhatta" , Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver Message-ID: <20150924091034.GB27847@shlinux2> References: <1443012841-13673-1-git-send-email-sbhatta@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1443012841-13673-1-git-send-email-sbhatta@xilinx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD038;1:EcvDIGPLXHcUElqba4PpmdOSeGQ+iHplyWQEyTDWtIHmu/hRZbx8V6suV6tFBgBsJWadNrjz8r/G4f4k5/oBGR9+6po4EZ97bQTlTvK3vavSEaLHkYVCOPlLkMpRy0W/7792j9OUjCpkoTarBW1MQDM1Fk5dVOFxbrAKjS0eQUKybChdUx5AFSyBin1+J5BQFY/H4bxd/+7XoCx4yluHMKQROSWoHaRhGxZ7KJyRbMnJM92ti9SjnxzGmVmAuRy35avFYl1A3BsUJJsf8hQ3XDHnbYGwOvG4CU6CRdV5ICLESILRp0SM6+YovWzdFkKV187wFcAqY9G++DbxSmveAABUZLeezLsiXAI4jNQ2y0mZrGPaXYm0DBVjJRr2IiFk0JsO6W2SvzNYhr3Z52hgGA== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(189002)(199003)(46102003)(6806005)(19580405001)(19580395003)(83506001)(47776003)(87936001)(104016004)(46406003)(23726002)(64706001)(86362001)(85426001)(11100500001)(33656002)(4001540100001)(81156007)(4001350100001)(5001860100001)(5001830100001)(54356999)(50986999)(76176999)(97736004)(97756001)(33716001)(50466002)(77096005)(68736005)(106466001)(189998001)(77156002)(110136002)(62966003)(5001960100002)(2950100001)(92566002)(5007970100001)(105606002)(7059030)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR03MB493;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB493;2:of0BCmGIhERorXgpiWg4tzIfB6+SP6ZYn+QP4MfmR/OmzKavW/L8dzOX9caHsvJDPtoz+8VY6CQCbd5kvh4Ii6CBNMU7BP/uQsaxWUrcZOdQQad1LtLGcEVuPrAApXAiWvnbguDeDcPdkQ1aNycrySpd+nUWtGpfalBon1UHqsQ=;3:zxg/zcbW1yvbqzs3F+2NRPfP0Io0UmcvCNrGQae+wxgIYYMeIIg/4nKLjpqgVHbfl3NXlx19F3Q+up6pz2zz6NpD8X2jAJCNTRpH8TxfFtYOTW6SvjDFIjjXlh37b+njQ9FROsTk9bizf7tFK/zEXwsSnXQhvrhK/FpSVfGtXPzMC41eX3BHmUsxQQECXULFq4vKoqsRXbjWQjbv1tmQKvbziDdk96I6gGjVdqSPbrs=;25:NN8+g1oWMqzZHkzo0Oqd2l/ZVrT18HAwQQCgq2+zkoBIjomHyYoT1wY4VKyphdkp0QfaX7QeMQarND70UdhR2Xuaj7wN2ycqnVKhidXBi1q542hSWtJw8mTlL3Ah8NQOjd255Bc3gLexrECAdRuqQY4ehbU7a77A413ja2PixemkV6v1OM9VdaAnsfiQorCpNRALToiY68zrvGh+dPp44bO8PsfC6B0V+YtLoezYOKKLrySp+ELt1XiCD2/0cGrqPKsBqyb5++Qts7tQIDgsmg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB493; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB493;20:5Z413kglfNBy/NJbYVDTI8JlxX/txadeK1Ah0Nfkuq6bYT7AfOSFa3WUMoW5y+mwQcVMWr7QDhQFHxmO6eYJ18zHZrvEwJU8ioSDyXK7pCjLe3IlMDHJzyJzSo9o3+4xPtenlZB3PlEoiMBSUa/gcJ3Bo/4RxzN9VL974dNuFo93ZvXoEXFmuLwXZFe2gND980nw2pzke3weLF2SEXIm/sDpF7EskyDMyHsKdkTbv29Xu/bIH9YyrlgD6TmB5gzELtNfDkejHynbeh8U+3v3bu7f2nLlRUqL0opgO6NYiynuT3cOe3kQHP2cOcljfu+mb80dTer2wy0st8Cmh9oqtojE/9vvCmdwlBhlzYMqSqI=;4:5MKJR2h7dwLgCMDMs8f/EHl7fK5R+iE7qhNhkX1Sj1ZqtKC1NCLQxEhtCZGJhSDo3r4uGgyv5NtuwRouIUaDjQsTXMrjIzYHE25Vo+ayYwW8zHVp5dMbGOnjZzLmjvC+aoRH8wbxoyWLKnbQf8khK3KWhfOpRrjC72OmtawN3StiKzKpOte6j+FaC1nAI5p95fDNQLoXUP2TGLfb9w3ENUnf6eC6N/JvSRHdCpwbFBtZFC8Gz0sF5qusVZ6pZgbgw3nXMv75seXmxM4LI0Ymx7RZagTuFAjBCfGB8kQX68z62Uq0Rf95reMA1MYvH/x3dQZupeUBVlBXZRNlC3HdvJZ4VGISngtLrp9Tfy79zws= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:DM2PR03MB493;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB493; X-Forefront-PRVS: 070912876F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR03MB493;23:taguRUVeoRUZN+++E8PLYesXdFLXbLDzsw/kf64eDJ?= =?us-ascii?Q?3U8TkwAilbMcVv71IKaIMaiB95aXmD57Dydpi8GH8gytXwXr/5AaxVXRHPgf?= =?us-ascii?Q?BpqOzLawe7iOqDE++DBH3n9tk/cqA1UPa144E6y2i268Q5QajjNpyxR/rDWa?= =?us-ascii?Q?wXoHNQ0JDx+UMF7RmTrposGK5FRhjPTBq9AGlMWVN4VOIW9KJubOF4zW6f+C?= =?us-ascii?Q?sxR2GVVXoEA8mA2aeYdcBZaqOWyJ1xDNUi67jKvA6WwHGOYGNDOI/GQprQ2A?= =?us-ascii?Q?Y9EZY1/3eE3zQZmx22EMlI3XgNyhTCMU+5WCSy4MSOnjXiVnMKNC3AQ9slvM?= =?us-ascii?Q?I0pH6IVzybN2TZc4y+u/WejiDXFOxvxgCd0ZjEspcptuRhHRsLo14addQvRS?= =?us-ascii?Q?ruKXuYH3ffpCX+FGsVdwsc87PWpx+H3CxE2nhdVIOihQpkXhY8yr67AhffLK?= =?us-ascii?Q?bm3+CpqhrCsTf70ge95DW2nLGFD4zjXFwpPsHz2tDHAOU62a6L+5G22B6NGM?= =?us-ascii?Q?3VrYB5iu/H8DxASNciC/kcgotJnNwfRRGjRvpN9P9abYOMzooC3mg/l0slKy?= =?us-ascii?Q?CVTi3xQL3kw04vNzcphd98oP0A2U0uDOQGD9N6WAkoGlAM8LcMrycRJRwfqS?= =?us-ascii?Q?/evw5BHJG6TaHGVuNmcbFSXiwfRnwwwCISOVgq1r+a/HtwVbtHI5Jre/mfkJ?= =?us-ascii?Q?UFodg6zmMW8QRhX+DptUzA41nTIit5PNf2rdtbnL97WAut8zt/PXjrrbENAj?= =?us-ascii?Q?0r/a+/DZ37tVyeidr7r1JA3Am5PSToEukkIet1+ty4xwwfL+rZ8z3qgdS0oF?= =?us-ascii?Q?QBeIMBOINUOPjaypRTleKR8YA4xc4ncsxPM/FzzasR/AV5kcY9B1P8bHemAP?= =?us-ascii?Q?/wONjndVx0Q0IIJB90B6pxopX0/bpV2QrsM7ACfSENEMfwPdxfedRjSWK5QL?= =?us-ascii?Q?Rlq9UTgufsC+EEDoXIpzLOWJPCOIQ5jHMAnHpv9E4dJ8vv6bhblH7gph2Z9x?= =?us-ascii?Q?PcZayf1jGJ7SubZCWvL7CbrTJYIuxP4hVi5cpE3zrpqdbxjP+8zTLyV6xAv8?= =?us-ascii?Q?esfv3eZK0c1eMU1Teod40fBAeOA+n7iQmePX0ogsi6MO7KafUmTR3QAORiYN?= =?us-ascii?Q?ajHE2j8UWKA48oz0gV5X4QSVFk7fNWubzdg4JfW2mic5kK7QfdxJqO1SrWZW?= =?us-ascii?Q?fp6j3EVt6h91RdM4kkmK5xVr0prRhjVoU8higNcm4nTS3slbVIdrVJdudsUW?= =?us-ascii?Q?yD4LlJOQLRsjbvAe9BS8fluNVgcYNVRFkIRBB2dEzNLVX6ouSriSmtDimaNQ?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB493;5:26ZXEdBDzlAKuKbNBrerprSyro4LtZRH0eIYmOpWEl29qbcPBXDsQrphfRk77mZtAUSWLFPVaPKE5KSS19kg0XXSZZXU/+SCmByAuB2UvSc8buyZvSGotbgvanVsC+rbkfy+hMiO7VV1PdpXxNc7hw==;24:+575P5S0WobeKnW1YVSGpkkPmhki87AVaPkdo97ZLch5mtvpe4+cPYCneyjJN+9b1dl4jxxXPnred3Z27azE8PQ3EH0uc69jVsWuvYFdDts=;20:xgOqUEmQCPoawq9JrZ2gSYDJNVtiyxgfzssuf60/ZCPBC0bKebigoSn9GZ+MmKf0Tiy7PwPUt2OkYo+4y+//aA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2015 09:10:48.4813 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB493 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2015 at 06:24:01PM +0530, Subbaraya Sundeep Bhatta wrote: > This patch adds binding doc info for generic ULPI PHYs > platform driver. > > Signed-off-by: Subbaraya Sundeep Bhatta > --- > .../devicetree/bindings/usb/ulpi-platform-phy.txt | 34 ++++++++++++++++++++ > 1 files changed, 34 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt > > diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt > new file mode 100644 > index 0000000..7b8cbb4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt > @@ -0,0 +1,34 @@ > +Platform driver for generic ULPI PHYs > + > +Required properties: > +- compatible : Should be "ulpi-phy" > +- reg : Physical base address and size of the USB > + controller registers map to which this PHY > + is connected. > +- view-port : Should contain viewport register offset of the > + USB controller to which this PHY is connected > +Optional properties: > +- drv-vbus : required if turning VBUS on/off has to be driven > + by writing to PHY. This feature depends on board > + design. > + > +Example: > +Below example shows the PHY binding for Chipidea USB controller which has > +ulpi viewport register at 0x0170 > + > + usb_phy0: phy0 { > + compatible = "ulpi-phy"; > + reg = <0xe0002000 0x1000>; > + view-port = <0x0170>; > + drv-vbus; > + }; > + > + usb0: usb@e0002000 { > + compatible = "chipidea,usb2"; > + interrupt-parent = <&intc>; > + interrupts = <0 21 4>; > + reg = <0xe0002000 0x1000>; Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list. > + phy_type = "ulpi"; > + dr_mode = "host"; > + usb-phy = <&usb_phy0>; > + }; > -- > 1.7.1 > -- Best Regards, Peter Chen