From: Peter Chen <peter.chen@freescale.com>
To: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kishon@ti.com" <kishon@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Punnaiah Choudary Kalluri" <punnaia@xilinx.com>
Subject: Re: [RFC PATCH 2/2] usb: phy: Add platform driver support for ULPI PHYs
Date: Thu, 24 Sep 2015 17:43:31 +0800 [thread overview]
Message-ID: <20150924094330.GC27847@shlinux2> (raw)
In-Reply-To: <F1B223389110CE49B4CF055ABA2E5D3D78C9BCA7@XAP-PVEXMBX02.xlnx.xilinx.com>
On Thu, Sep 24, 2015 at 09:21:16AM +0000, Subbaraya Sundeep Bhatta wrote:
> > > +uphy->flags);
> > > +
> > > + uphy->usb_phy->set_vbus = usbphy_set_vbus;
> >
> > When you will call it?
>
> I am calling it in host.c and otg_fsm.c of Chipidea driver wherever
> regulator_enable/disable is called to control VBUS like below:
>
> if (ci->platdata->flags & CI_HDRC_PHY_VBUS_CONTROL) {
> if (enable)
> ci->usb_phy->set_vbus(ci->usb_phy, 1);
> else
> ci->usb_phy->set_vbus(ci->usb_phy, 0);
> }
>
> After these changes host mode and otg modes works fine
> for my case.
>
Get it, there are several vbus control ways, I may need to consolidate
them, of cos, this is another topic.
--
Best Regards,
Peter Chen
prev parent reply other threads:[~2015-09-24 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 12:54 [RFC PATCH 2/2] usb: phy: Add platform driver support for ULPI PHYs Subbaraya Sundeep Bhatta
2015-09-24 9:06 ` Peter Chen
2015-09-24 9:21 ` Subbaraya Sundeep Bhatta
2015-09-24 9:43 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924094330.GC27847@shlinux2 \
--to=peter.chen@freescale.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=punnaia@xilinx.com \
--cc=subbaraya.sundeep.bhatta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).