From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753627AbbIXK1a (ORCPT ); Thu, 24 Sep 2015 06:27:30 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36725 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbbIXK12 (ORCPT ); Thu, 24 Sep 2015 06:27:28 -0400 Date: Thu, 24 Sep 2015 15:57:22 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: Punit Vara , devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment Message-ID: <20150924102722.GB11025@sudip-pc> References: <1443039862-6197-1-git-send-email-punitvara@gmail.com> <20150924090001.GK4953@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150924090001.GK4953@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote: > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote: > > This is a patch to the rtl871x_mp.h that fixes up following warnings > > reported by checkpatch.pl : > > > > -Block comments use a trailing */ on a separate line > > > > Signed-off-by: Punit Vara > > --- > > drivers/staging/rtl8712/rtl871x_mp.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h > > index 75893f2..20a4273 100644 > > --- a/drivers/staging/rtl8712/rtl871x_mp.h > > +++ b/drivers/staging/rtl8712/rtl871x_mp.h > > @@ -108,7 +108,8 @@ struct mp_priv { > > unsigned char network_macaddr[6]; > > /*Testing Flag*/ > > u32 mode;/*0 for normal type packet, > > This first line is missing some spaces so the whole comment needs to be > redone. > > u32 mode; /* 0 for normal type packet, > * 1 for loopback packet (16bytes TXCMD) > */ If he is modifying the first line then shouldn't it be: u32 mode; /* * 0 for normal type packet, * 1 for loopback packet (16bytes TXCMD) */ regards sudip