From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbbIXO3Z (ORCPT ); Thu, 24 Sep 2015 10:29:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49633 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbbIXO3Y (ORCPT ); Thu, 24 Sep 2015 10:29:24 -0400 Date: Thu, 24 Sep 2015 11:29:19 -0300 From: Arnaldo Carvalho de Melo To: Matt Fleming Cc: Jiri Olsa , Vinson Lee , rostedt@goodmis.org, Jiri Olsa , raphael.beamonte@gmail.com, "H. Peter Anvin" , LKML , Peter Zijlstra , David Ahern , Ingo Molnar , Thomas Gleixner , Namhyung Kim , linux-tip-commits@vger.kernel.org, Michael Petlan Subject: Re: [tip:perf/core] tools lib api fs: Remove debugfs, tracefs and findfs objects Message-ID: <20150924142919.GA2484@redhat.com> References: <1441180605-24737-15-git-send-email-jolsa@kernel.org> <20150923082302.GA2867@codeblueprint.co.uk> <20150923083906.GB2024@krava.redhat.com> <20150923134456.GD5041@redhat.com> <20150924121551.GB2791@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150924121551.GB2791@codeblueprint.co.uk> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Sep 24, 2015 at 01:15:51PM +0100, Matt Fleming escreveu: > On Wed, 23 Sep, at 10:44:56AM, Arnaldo Carvalho de Melo wrote: > > Of course, in these days of CI, I'd love if someone would hook 'make -C > > tools/perf build-test' and 'perf test' somewhere to be run for every > > changeset. > > Yes please! But then even this one would have not been caught, because the test in place don't include trying to build tools/vm/, i.e. from time to time something will pass and will be caught by people like Vinson, reported and fixed :-) > > BTW, tools/vm/ was reported yesterday and a fix is already in > > tip/perf/core/: > > > > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/tools/vm?id=f6489bc2d402c0db84aa64f13b864d17f7eecb07 > > > > Age Commit message (Expand) Author Files Lines > > 12 hours tools vm: Fix build due to removal of tools/lib/api/fs/debugfs.h Arnaldo Carvalho de Melo 1 -3/+3 > It's not that this wasn't fixed quickly (kudos for that, btw), rather > it's that the breakage should have been avoided altogether. > But if this is an isolated incident, then fair enough, I'll stop > whining. Expressing concern is not a problem, its an opportunity for us to try and get them addressed and improve so that others don't get afraid of the processes in place. - Arnaldo