Re: [PATCH 2/3] nohz: mark tick_nohz_init_all() as __init

[Frederic Weisbecker <fweisbec@gmail.com>]

On Thu, Sep 10, 2015 at 03:58:26PM -0400, Luiz Capitulino wrote:
> It's only called by tick_nohz_init().
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  kernel/time/tick-sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index 8d45638..4cc6df03 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -308,7 +308,7 @@ static int tick_nohz_cpu_down_callback(struct notifier_block *nfb,
>  	return NOTIFY_OK;
>  }
>  
> -static int tick_nohz_init_all(void)
> +static int __init tick_nohz_init_all(void)
>  {
>  	int err = -1;

For some reasons I thought sections don't apply to static functions. Well I still don't know
but I guess it works as long as the function doesn't get inlined. Or likely it prevents it from
being inlined.

Anyway, I think we can take the patch.

Thanks.


>  
> -- 
> 2.1.0
>