From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753351AbbIXOeB (ORCPT ); Thu, 24 Sep 2015 10:34:01 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37911 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbbIXOeA (ORCPT ); Thu, 24 Sep 2015 10:34:00 -0400 Date: Thu, 24 Sep 2015 16:33:57 +0200 From: Frederic Weisbecker To: Luiz Capitulino Cc: linux-kernel@vger.kernel.org, cmetcalf@ezchip.com Subject: Re: [PATCH 2/3] nohz: mark tick_nohz_init_all() as __init Message-ID: <20150924143356.GA8569@lerouge> References: <1441915107-2000-1-git-send-email-lcapitulino@redhat.com> <1441915107-2000-3-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441915107-2000-3-git-send-email-lcapitulino@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2015 at 03:58:26PM -0400, Luiz Capitulino wrote: > It's only called by tick_nohz_init(). > > Signed-off-by: Luiz Capitulino > --- > kernel/time/tick-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > index 8d45638..4cc6df03 100644 > --- a/kernel/time/tick-sched.c > +++ b/kernel/time/tick-sched.c > @@ -308,7 +308,7 @@ static int tick_nohz_cpu_down_callback(struct notifier_block *nfb, > return NOTIFY_OK; > } > > -static int tick_nohz_init_all(void) > +static int __init tick_nohz_init_all(void) > { > int err = -1; For some reasons I thought sections don't apply to static functions. Well I still don't know but I guess it works as long as the function doesn't get inlined. Or likely it prevents it from being inlined. Anyway, I think we can take the patch. Thanks. > > -- > 2.1.0 >