From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881AbbIXOxe (ORCPT ); Thu, 24 Sep 2015 10:53:34 -0400 Received: from mail-yk0-f177.google.com ([209.85.160.177]:36095 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756646AbbIXOxV (ORCPT ); Thu, 24 Sep 2015 10:53:21 -0400 Date: Thu, 24 Sep 2015 10:53:17 -0400 From: Tejun Heo To: Andrzej Hajda Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-ide@vger.kernel.org Subject: Re: [PATCH 03/19] libata: samsung_cf: fix handling platform_get_irq result Message-ID: <20150924145317.GA25415@mtj.duckdns.org> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> <1443103227-25612-4-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443103227-25612-4-git-send-email-a.hajda@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 04:00:11PM +0200, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > Hi, > > To avoid problems with too many mail recipients I have sent whole > patchset only to LKML. Anyway patches have no dependencies. Can we just change s3c_ide_info->irq to int instead? Thanks. -- tejun