From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755370AbbIXRLP (ORCPT ); Thu, 24 Sep 2015 13:11:15 -0400 Received: from mail.skyhub.de ([78.46.96.112]:42928 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbbIXRLN (ORCPT ); Thu, 24 Sep 2015 13:11:13 -0400 Date: Thu, 24 Sep 2015 19:11:09 +0200 From: Borislav Petkov To: Seth Jennings Cc: Mauro Carvalho Chehab , Tony Luck , Aristeu Rozanski , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sb_edac: fix TAD presence check for sbridge_mci_bind_devs() Message-ID: <20150924171109.GI3774@pd.tnic> References: <1438798561-10180-1-git-send-email-sjenning@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1438798561-10180-1-git-send-email-sjenning@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2015 at 01:16:01PM -0500, Seth Jennings wrote: > In 7d375bff, NUM_CHANNELS was changed to 8 and the channel space was > renumerated to handle EN, EP, and EX configurations. > > The *_mci_bind_devs functions, except for sbridge_mci_bind_devs(), got a > new device presence check in the form of saw_chan_mask. However, > sbridge_mci_bind_devs() still uses the NUM_CHANNELS for loop. > > With the increase in NUM_CHANNELS, this loop fails at index 4 since > SB only has 4 TADs. This results in the following error on SB machines: > > EDAC sbridge: Some needed devices are missing > EDAC sbridge: Couldn't find mci handler > EDAC sbridge: Couldn't find mci handle > > This patch adapts the saw_chan_mask logic for sbridge_mci_bind_devs() as > well. > > After this patch: > > EDAC MC0: Giving out device to module sbridge_edac.c controller Sandy Bridge Socket#0: DEV 0000:3f:0e.0 (POLLED) > EDAC MC1: Giving out device to module sbridge_edac.c controller Sandy Bridge Socket#1: DEV 0000:7f:0e.0 (POLLED) > > Signed-off-by: Seth Jennings > --- > drivers/edac/sb_edac.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.