From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755326AbbIYHz1 (ORCPT ); Fri, 25 Sep 2015 03:55:27 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36789 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754603AbbIYHzY (ORCPT ); Fri, 25 Sep 2015 03:55:24 -0400 Date: Fri, 25 Sep 2015 16:56:10 +0900 From: Sergey Senozhatsky To: Joonsoo Kim Cc: Sergey Senozhatsky , Andrew Morton , Minchan Kim , Nitin Gupta , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Stephan Mueller Subject: Re: [PATCH v3 1/9] crypto: introduce decompression API that can be called via sharable tfm object Message-ID: <20150925075610.GD865@swordfish> References: <1442553564-3476-1-git-send-email-iamjoonsoo.kim@lge.com> <1442553564-3476-2-git-send-email-iamjoonsoo.kim@lge.com> <20150921061817.GC5313@swordfish> <20150925052617.GB7158@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150925052617.GB7158@js1304-P5Q-DELUXE> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/25/15 14:26), Joonsoo Kim wrote: [..] > > > +struct crypto_comp *crypto_alloc_comp_noctx(const char *alg_name, > > > + u32 type, u32 mask); > > > + > > > > this should be EXPORT_SYMBOL_GPL(). > > > > Will do in next version. > so you want to go with _noctx() callbacks implementation? that CRYPTO_ALG_TFM_MAY_SHARE flag looks quite simple to me. or you guys hate it? -ss